[openai, openai-agents] Use concrete invocation types in raw response and robust mock assertions - #744
Merged
lmolkova merged 1 commit intoSep 20, 2026
Conversation
lmolkova
force-pushed
the
fix/openai-agents-mock-and-error-imports
branch
from
September 19, 2026 06:43
8d45009 to
82d2153
Compare
Pull request dashboard statusMerged · refreshed 2026-09-20 05:11 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review effort: Lite
Findings: None
What changed in this PR
This PR aligns Error imports with the public invocation API and makes the capture-disabled mock test independent of class-level properties.
Changes:
- Imports
Errorfromopentelemetry.util.genai.invocation. - Uses sentinel objects to verify tool content remains untouched.
| File | Description |
|---|---|
| instrumentation/opentelemetry-instrumentation-genai-openai/src/opentelemetry/instrumentation/genai/openai/response_wrappers.py | Updated as part of this pull request. |
| instrumentation/opentelemetry-instrumentation-genai-openai-agents/tests/test_processor.py | Updated as part of this pull request. |
| instrumentation/opentelemetry-instrumentation-genai-openai-agents/src/opentelemetry/instrumentation/genai/openai_agents/processor.py | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…assertions in OpenAI Agents
lmolkova
force-pushed
the
fix/openai-agents-mock-and-error-imports
branch
from
September 19, 2026 06:46
82d2153 to
66f6eef
Compare
lmolkova
changed the title
lmolkova
changed the title
eternalcuriouslearner
approved these changes
Sep 19, 2026
github-project-automation
Bot
moved this to Done
in GenAI Semantic Conventions and Instrumentation libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Uses
_StreamingInvocationin_raw_response.pyand updatestest_function_span_skips_content_when_capture_disabledto verify mocked tool invocation arguments and results remain untouched using sentinels instead of expectingAttributeError.Why?
Removes the last remaining
GenAIInvocationusage in instrumentations and decouples mock tests from whetherToolInvocationdefines properties on the class.