[exporter/datadog] trim whitespace from hostname - #50945
Open
chandan009s wants to merge 2 commits into
Open
Conversation
chandan009s
requested review from
a team,
mx-psi and
songy23
as code owners
September 13, 2026 05:48
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
github-actions
Bot
requested review from
IbraheemA,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
September 13, 2026 05:48
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-13 22:39 UTC Review the latest changes. Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the Datadog exporter hostname is configured using the
${file:}provider,the trailing newline from the file is preserved and causes hostname validation
to fail.
This change trims surrounding whitespace from the configured hostname during
unmarshalling so file-based hostnames such as
my-hostname\nare accepted.Link to tracking issue
Fixes #50935
Testing
Added a regression test covering a hostname with a trailing newline.
Tests run:
go test ./...inpkg/datadog/configDocumentation
No documentation changes.
Authorship