[intervalprocessor] Add delta temporality metrics support - #50922
Open
SumitDalavi wants to merge 1 commit into
Open
[intervalprocessor] Add delta temporality metrics support#50922SumitDalavi wants to merge 1 commit into
SumitDalavi wants to merge 1 commit into
Conversation
Currently, intervalprocessor ignores delta temporality metrics and simply passes them through. This PR adds support for accumulating delta metric values across the interval using a local copy of the deltatocumulativeprocessor's data addition utilities. Fixes open-telemetry#50845.
SumitDalavi
force-pushed
the
issue-50845-delta-temporality-intervalprocessor
branch
from
September 11, 2026 16:28
3ba8c72 to
748f3a9
Compare
Contributor
Author
|
Hi! I've opened this PR to add delta temporality metrics support for the \intervalprocessor. To keep this as a minimal and safe change (without risking regressions in the existing \deltatocumulativeprocessor), I duplicated the data-addition logic into \intervalprocessor/internal/data. However, as a future improvement or if reviewers prefer doing it in this PR, I propose we extract these data-addition utilities into a shared internal package (e.g., \internal/exp/metrics/data). Looking forward to your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
intervalprocessorignores delta temporality metrics and simply passes them through. This PR adds support for accumulating delta metric values across the interval using a local copy of thedeltatocumulativeprocessor's data addition utilities.To maintain the "smallest maintainable change" principle and avoid breaking the existing
deltatocumulativeprocessor, the data-addition logic was localized intointervalprocessor. (We can extract this into a sharedinternal/exp/metrics/datapackage in a future PR if desired).Link to tracking issue
Fixes #50845
Testing
intervalprocessortests to assert that delta metrics are properly aggregated over intervals.processor/intervalprocessor/...pass cleanly.Documentation
Authorship