[cmd/opampsupervisor] Make the Collector stop grace period configurable - #50916
Open
singhvibhanshu wants to merge 1 commit into
Open
Conversation
Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
singhvibhanshu
requested review from
a team,
atoulme,
evan-bradley and
tigrannajaryan
as code owners
September 11, 2026 10:31
mwear
reviewed
Sep 11, 2026
|
|
||
| func NewCommander(logger *zap.Logger, logFilePath string, cfg config.Agent, args ...string) (*Commander, error) { | ||
| stopGracePeriod := cfg.StopGracePeriod | ||
| if stopGracePeriod <= 0 { |
Member
There was a problem hiding this comment.
validate allows a user to set the grace period to 0. However, this will convert 0 into 10s (the default). Should 0 mean no grace period?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
agent::stop_grace_periodconfig option controlling how long the Supervisor waits for the Collector to exit after a graceful shutdown signal before forcibly killing it. It defaults to 10s, andNewCommanderfalls back to the default when unset.Link to tracking issue
This is a follow - up PR for #50000. Specifically this comment.
Testing
Tuned.
Documentation
Tuned.
Authorship