Skip to content

[pkg/translator/zipkin] Promote HTTP and Scope SemConv feature gates to Beta - #50910

Open
singhvibhanshu wants to merge 4 commits into
open-telemetry:mainfrom
singhvibhanshu:promote-zipkin-http-scope-gates-beta
Open

[pkg/translator/zipkin] Promote HTTP and Scope SemConv feature gates to Beta#50910
singhvibhanshu wants to merge 4 commits into
open-telemetry:mainfrom
singhvibhanshu:promote-zipkin-http-scope-gates-beta

Conversation

@singhvibhanshu

Copy link
Copy Markdown
Member

Description

This PR promotes the pkg.translator.zipkin.EmitV1HttpConventions, DontEmitV0HttpConventions, EmitV1ScopeConventions, and DontEmitV0ScopeConventions feature gates from Alpha to Beta, enabling them by default. The gates have been Alpha since v0.154.0 (#48904) and have soaked for six minor releases without reported issues. With them enabled, the Zipkin translator emits the semconv v1.40.0 attributes http.response.status_code, otel.scope.name, and otel.scope.version by default instead of the deprecated http.status_code, otel.library.name, and otel.library.version respeectively

This PR also pins the affected gates explicitly in the tests: TestZipkinAnnotationsToSpanStatus holds the HTTP gates disabled to keep covering the deprecated attribute output, and TestExtractScopeTags pins the Scope gates per-case so both the v0 and v1 scope attributes stay covered after the default flips.

Link to tracking issue

Fixes #50909

Testing

Tuned.

Documentation

Tuned.

Authorship

  • I, a human, wrote this pull request description myself.

Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 11, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-09-11 12:51 UTC

Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):

  • Top-level threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

@singhvibhanshu

Copy link
Copy Markdown
Member Author

/rerun

@andrzej-stencel andrzej-stencel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need updating

Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
@github-actions github-actions Bot added the receiver/zipkin Zipkin receiver label Sep 11, 2026
@singhvibhanshu

singhvibhanshu commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

Tests need updating

Hi @andrzej-stencel 👋
I've updated the tests accordingly. One question I have and want to discuss it with you is: correctness-traces failure on the CI which comes from a coupling I want to check with you before deciding how to split this.

The golden dataset (internal/coreinternal/goldendataset) has its own HTTP SemConv gates, but they're still alpha and unlike the other attributes, http.status_code is emitted unconditionally there (never wired to the gate). So in the trace round-trip, the golden data sends v0 http.status_code while this PR makes the zipkin translator emit v1 http.response.status_code, and the validator flags the mismatch.

I confirmed by it running the E2E correctness-traces tests in each state:

  • both zipkin + goldendataset HTTP gates at beta: passes
  • either one alone: fails

The two are effectively coupled: http.status_code round-trips through a tag rename plus the exporter's v0 shim, so the golden dataset and the translator have to flip together

Given that, how would you prefer to proceed?

  1. Include the goldendataset change in this same PR, or
  2. Keep this PR focused on the zipkin gates and do the goldendataset promotion as a coordinated follow-up. Just a note that correctness-traces would stay red until both land.

I have the goldendataset change ready, btw.

@paulojmdias

Copy link
Copy Markdown
Member

Yes, you need to update the goldendataset side on this PR either.

Look into #46533 for example

Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
@singhvibhanshu

Copy link
Copy Markdown
Member Author

@paulojmdias,
I've pushed the changes but the CI is still failing, and here’s the probable reason I see for it:

--- FAIL: TestTracingGoldenData (18.23s)
    --- PASS: TestTracingGoldenData/zipkin-otlp_grpc (3.04s)
    --- PASS: TestTracingGoldenData/otlp-zipkin (3.05s)
    --- PASS: TestTracingGoldenData/jaeger-zipkin (3.03s)
    --- PASS: TestTracingGoldenData/otlp-otlp_grpc (3.04s)
    --- FAIL: TestTracingGoldenData/jaeger-otlp_grpc (3.03s)
    --- PASS: TestTracingGoldenData/zipkin-zipkin (3.04s)

We need to promote Jaeger FG to beta as well to get this green, but I don’t think adding those changes here would make much sense, as it would unnecessarily make the PR bigger.

Could you please help me here in deciding what should I need to do next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pkg/translator/zipkin] Promote HTTP and Scope SemConv feature gates to Beta

3 participants