[pkg/translator/zipkin] Promote HTTP and Scope SemConv feature gates to Beta - #50910
[pkg/translator/zipkin] Promote HTTP and Scope SemConv feature gates to Beta#50910singhvibhanshu wants to merge 4 commits into
Conversation
Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
Pull request dashboard statusWaiting on the author · refreshed 2026-09-11 12:51 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
|
/rerun |
Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
Hi @andrzej-stencel 👋 The golden dataset ( I confirmed by it running the E2E correctness-traces tests in each state:
The two are effectively coupled: Given that, how would you prefer to proceed?
I have the goldendataset change ready, btw. |
|
Yes, you need to update the goldendataset side on this PR either. Look into #46533 for example |
Signed-off-by: singhvibhanshu <find.vibhanshu@gmail.com>
|
@paulojmdias, We need to promote Jaeger FG to beta as well to get this green, but I don’t think adding those changes here would make much sense, as it would unnecessarily make the PR bigger. Could you please help me here in deciding what should I need to do next? |
Description
This PR promotes the
pkg.translator.zipkin.EmitV1HttpConventions,DontEmitV0HttpConventions,EmitV1ScopeConventions, andDontEmitV0ScopeConventionsfeature gates from Alpha to Beta, enabling them by default. The gates have been Alpha sincev0.154.0(#48904) and have soaked for six minor releases without reported issues. With them enabled, the Zipkin translator emits the semconv v1.40.0 attributeshttp.response.status_code,otel.scope.name, andotel.scope.versionby default instead of the deprecatedhttp.status_code,otel.library.name, andotel.library.versionrespeectivelyThis PR also pins the affected gates explicitly in the tests:
TestZipkinAnnotationsToSpanStatusholds the HTTP gates disabled to keep covering the deprecated attribute output, andTestExtractScopeTagspins the Scope gates per-case so both the v0 and v1 scope attributes stay covered after the default flips.Link to tracking issue
Fixes #50909
Testing
Tuned.
Documentation
Tuned.
Authorship