Skip to content

[pkg/ottl]: move profile support to new xprofile module - #50906

Open
TylerHelmuth wants to merge 11 commits into
open-telemetry:mainfrom
TylerHelmuth:ottl-move-profiles
Open

[pkg/ottl]: move profile support to new xprofile module#50906
TylerHelmuth wants to merge 11 commits into
open-telemetry:mainfrom
TylerHelmuth:ottl-move-profiles

Conversation

@TylerHelmuth

Copy link
Copy Markdown
Member

Description

Moves all of OTTL's profile support into an x module so that it can be tagged separately from OTTL. This will allow OTTL to be tagged 1.0 without tagging profile support 1.0.

This is a big refactor. I chose pkg/ottl/contexts/xprofile so that it could easily depend on all the internal packages from contexts. If we want it to live at the root of OTTL we'd have to move a lot of pkg/ottl/contexts/internal to pkg/ottl/internal, which I wanted to avoid.

The only new content is in xprofiles/ottlfuncs/functions.go which handles the profile functions. It includes a WithProfileConverters helper to make it easier to add the profile functions to all our components which support ProfileID converter.

Link to tracking issue

Testing

Lots of updated tests, but no new test cases.

Documentation

Updated the ottlfuncs readme to reference the experimental functions, but not list them since they are not included in the standard helpers anymore.

Authorship

  • I, a human, wrote this pull request description myself.

Comment thread .chloggen/ottl-profiles-xprofile-module.yaml Outdated
Comment thread pkg/ottl/contexts/internal/ctxcommon/ids_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pkg/ottl] Move profiles support into a separate module to exclude it from OTTL's stability guarantees

2 participants