[pkg/ottl]: move profile support to new xprofile module - #50906
Open
TylerHelmuth wants to merge 11 commits into
Open
[pkg/ottl]: move profile support to new xprofile module#50906TylerHelmuth wants to merge 11 commits into
TylerHelmuth wants to merge 11 commits into
Conversation
TylerHelmuth
requested review from
a team,
ChrsMark,
VihasMakwana,
atoulme,
bogdandrutu,
braydonk,
crobert-1,
dehaansa,
dmitryax,
edmocosta,
evan-bradley,
jmacd,
mx-psi,
songy23 and
tigrannajaryan
as code owners
September 10, 2026 22:51
github-actions
Bot
requested review from
IbraheemA,
JaredTan95,
MikeGoldsmith,
VinozzZ,
akats7,
blakerouse,
boostchicken,
carsonip,
csmarchbanks,
dineshg13,
douglascamata,
dpaasman00,
greatestusername,
jade-guiton-dd,
jsvd,
lahsivjar,
liustanley,
mackjmr,
mwear,
portertech and
shalper2
September 10, 2026 22:53
TylerHelmuth
commented
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves all of OTTL's profile support into an
xmodule so that it can be tagged separately from OTTL. This will allow OTTL to be tagged 1.0 without tagging profile support 1.0.This is a big refactor. I chose
pkg/ottl/contexts/xprofileso that it could easily depend on all the internal packages fromcontexts. If we want it to live at the root of OTTL we'd have to move a lot ofpkg/ottl/contexts/internaltopkg/ottl/internal, which I wanted to avoid.The only new content is in
xprofiles/ottlfuncs/functions.gowhich handles the profile functions. It includes aWithProfileConvertershelper to make it easier to add the profile functions to all our components which support ProfileID converter.Link to tracking issue
Testing
Lots of updated tests, but no new test cases.
Documentation
Updated the ottlfuncs readme to reference the experimental functions, but not list them since they are not included in the standard helpers anymore.
Authorship