Repository navigation
feat: typed callbacks and errors #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ccfba72
feat: expose callback failures as {code, message}
loks0n 33b76e1
fix: validate every present callback error
loks0n 749d1b6
test: assert the null result directly
loks0n f4b9b0f
refactor: keep the envelope ignorant of its payload
loks0n 52e47fc
feat: type failure codes as an enum, drop the legacy string shape
loks0n 3177349
feat: typed callback payloads behind a generic CloudEvent
loks0n f1a3514
refactor: Payload is Callback, Failure is Error
loks0n 8815df7
fix: callbacks live in Callback, not Callback\Callback
loks0n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace OpenRuntimes\Orchestrator\Callback; | ||
|
|
||
| use OpenRuntimes\Orchestrator\Exception\ClientException; | ||
|
|
||
| /** | ||
| * The error carried by a failed callback: a stable snake_case code to branch | ||
| * on, and a sentence about this occurrence to show — never to parse. | ||
| */ | ||
| final readonly class Failure | ||
| { | ||
| public function __construct( | ||
| public string $code, | ||
| public string $message, | ||
| ) {} | ||
|
|
||
| /** | ||
| * Orchestrator 2.2 sends `{code, message}`; a 2.1 orchestrator mid-upgrade | ||
| * still sends the bare code as a string, so that is accepted with no message. | ||
| */ | ||
| public static function fromValue(mixed $error): self | ||
| { | ||
| if (\is_string($error) && $error !== '') { | ||
| return new self($error, ''); | ||
| } | ||
| if (! \is_array($error) || ! \is_string($error['code'] ?? null) || $error['code'] === '') { | ||
| throw new ClientException('Invalid callback error: missing string code.'); | ||
| } | ||
|
|
||
| $message = $error['message'] ?? ''; | ||
|
|
||
| return new self($error['code'], \is_string($message) ? $message : ''); | ||
|
loks0n marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.