Skip to content

feat: sync orchestrator 2.0 API - #15

Merged
loks0n merged 1 commit into
mainfrom
codex/sync-orchestrator-2.0
Sep 2, 2026
Merged

loks0n merged 1 commit into
mainfrom
codex/sync-orchestrator-2.0

Conversation

@loks0n

@loks0n loks0n commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the retired public deployment-pool and activation SDK surface
  • make sandbox creation use a complete image/port shape for transparent warm-pool matching
  • expose termination grace periods for deployments and sandboxes
  • update sandbox status, callback events, tests, and documentation for orchestrator 2.0

Validation

  • composer test
  • composer analyze
  • composer format:check
  • composer refactor:check

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR synchronizes the PHP SDK with orchestrator 2.0.

  • Removes the retired deployment-pool, activation, and pool-backed sandbox surfaces.
  • Requires sandboxes to declare their complete image and primary-port shape.
  • Adds termination grace-period request fields for deployments and sandboxes.
  • Updates sandbox status hydration, callback events, tests, and documentation.

Confidence Score: 5/5

The PR appears safe to merge, with the removed and updated public surfaces consistently reflected across implementation, models, tests, and documentation.

No concrete blocking or independently actionable non-blocking defect remains after checking the new request mappings, sandbox contract changes, retired pool APIs, and callback behavior.

Important Files Changed

Filename Overview
src/Sandboxes.php Replaces pool-or-image creation with required image and port inputs, adds termination-grace serialization, and removes pool inspection methods consistently with the documented 2.0 surface.
src/Deployments.php Adds optional terminationGracePeriodSeconds to deployment specifications using the existing nullable optional-field serialization pattern.
src/Model/SandboxStatus.php Removes poolId hydration in alignment with transparent warm-pool matching and updated response fixtures.
src/Enum/CallbackEvent.php Removes the retired pool activation event while preserving support for arbitrary callback event strings through the callback model.
src/DeploymentPools.php Deletes the retired deployment-pool client as part of the coordinated orchestrator 2.0 API removal.
tests/SandboxesTest.php Migrates sandbox coverage to the complete image-and-port request shape and verifies termination-grace serialization.
tests/DeploymentsTest.php Extends deployment request coverage to verify terminationGracePeriodSeconds serialization.

Reviews (1): Last reviewed commit: "feat: sync orchestrator 2.0 API" | Re-trigger Greptile

@loks0n
loks0n merged commit fa60334 into main Sep 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant