Repository navigation
feat(sandbox): read back the shape a sandbox runs in - #13
Merged
Merged
Conversation
Orchestrator 1.4.0 reports the image, cpu and memory a sandbox is running in on every sandbox status. It records them when the pod is created, so a caller that did not create the sandbox — or has forgotten what it asked for — can read what it got instead of keeping a record of its own. They are null for a sandbox created before the orchestrator recorded a shape. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Greptile SummaryAdds the image, CPU, and memory shape reported by Orchestrator 1.4.0 to
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security failures identified. All sandbox operations converge on the updated status hydrator, the numeric parser handles the documented JSON representations, and legacy responses remain compatible through optional null fields. Important Files Changed
Reviews (1): Last reviewed commit: "feat(sandbox): read back the shape a san..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orchestrator 1.4.0 reports the image, cpu and memory a sandbox is running in on every sandbox status. It records them when the pod is created, so a caller that did not create the sandbox — or has forgotten what it asked for — can read what it got instead of keeping a record of its own. They are null for a sandbox created before the orchestrator recorded a shape.
Comparing the orchestrator at
v1.3.1..HEAD, this is the only API-surface change for 1.4.0:pool.Status, deployments, jobs and artifacts are unchanged.SandboxStatusgainsimage,cpuandmemory, hydrated from every read.Data::optionalFloat(), which accepts an int — JSON gives2for a wholecpu, not2.0.composer test,analyze,refactor:checkandformat:checkall pass.The new fields sit before
errorin the constructor, mirroring the API docs' field order. That shiftserror's position, so a positionalnew SandboxStatus(...)would break — named arguments are the convention here and hydration goes throughfromArray(). Happy to append them at the end instead.🤖 Generated with Claude Code