forked from Y4suyuki/react-training
-
Notifications
You must be signed in to change notification settings - Fork 0
hooksに置き換え #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ookura-mf
wants to merge
19
commits into
training0
Choose a base branch
from
training1
base: training0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
hooksに置き換え #2
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fb221ec
何も考えずにまずはcomponent単位でファイルを分けてhooksに置き換えてみる
ookura-mf 314c49d
雑にeslintを導入してみる
ookura-mf 5661040
ちょっと設定見直した
ookura-mf 8443717
apply eslint
ookura-mf dacf409
ちょいルールを修正
ookura-mf b1aa906
eslit fix.
ookura-mf 28a34ff
component分割してみた
ookura-mf 4493c84
Add return type.
ookura-mf a4a7ff2
format
ookura-mf 38cb797
調べてみたらVFCはつけなくても良さそうだった
ookura-mf b71fd26
logicをusecase層に逃してみた
ookura-mf af4d565
useReducer使ってロジックをスッキリさせてみた
ookura-mf e0d2bcf
GameInfoのインターフェースをちょっと修正
ookura-mf 4baba96
rename component tsx files.
ookura-mf e291a32
お化粧直し
ookura-mf 879f136
Actionの定義をシンプルにしてみた
ookura-mf 9fd3816
Boardの行をコンポーネントに切り出した
ookura-mf c1c532a
useCallback使ってみた
ookura-mf 29f1b27
SquareValueをもうちょっと意味のある単語に変えてみた
ookura-mf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| export type SquareValue = "X" | "O" | null; | ||
| export type Mark = "X" | "O" | null; | ||
| type SquareProps = { | ||
| value: SquareValue; | ||
| mark: Mark; | ||
| onClick: () => void; | ||
| }; | ||
|
|
||
| export const Square = (props: SquareProps) => { | ||
| return ( | ||
| <button className="square" onClick={props.onClick}> | ||
| {props.value} | ||
| {props.mark} | ||
| </button> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良いと思います 👍
僕もこうしました
後で若干nullを分けたくなるかもですがそんなに大した話ではないです