Roll the offer back when a re-INVITE cannot be sent - #1130
Open
23Skidoo wants to merge 1 commit into
Open
Conversation
invite() creates the offer and applies it before handing the request to the dialog, so a dialog that refuses to send leaves that offer in place. The session stays up and every attempt after it fails earlier still, while creating its description, because the peer connection is no longer stable. The same rollback already runs when a re-INVITE is answered non-2xx. This extends it to the case where the request never reached the wire.
23Skidoo
marked this pull request as ready for review
August 26, 2026 05:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session.invitecreates the offer and applies it before handing the request to the dialog, so a dialog that refuses to send leaves that offer in place. The session stays up and every attempt after it fails earlier still, while creating its description, because the peer connection is no longer stable.SessionManager.hold()sends its re-INVITE through this path, so one refused hold leaves a session that can never be held again.The same rollback already runs when a re-INVITE is answered non-2xx; this extends it to the case where the request never reached the wire. Note it has effect only once the web handler implements
rollbackDescription, proposed separately in #1129.This contribution was prepared with LLM assistance (Claude): the investigation, the change, and this description. A human reviewed it and stands behind the submission.