-
Notifications
You must be signed in to change notification settings - Fork 73
Add image class #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add image class #515
Changes from 90 commits
Commits
Show all changes
142 commits
Select commit
Hold shift + click to select a range
05977bd
feat: add image class
jo-mueller c64d653
feat: added reader
jo-mueller 22b11d8
feat: pass labels to multiscales writer function
jo-mueller c92a30d
fix: do not use v06 yet
jo-mueller ee80edc
test: add testcases for class-based writer
jo-mueller 46cf756
refactor: write scales to zarr group scale<idx>
jo-mueller 5d97ea9
fix: remove 0.6 conversion from reader
jo-mueller fa638cc
fix: accept storage options and scale_factors as list[dicts]
jo-mueller 2085929
tests: calculate expected shape correctly from array shapes
jo-mueller 0444af9
deps: add ome-zarr-models-py (latest) to dependencies
jo-mueller 83027e0
fix: use correct scale folder convention
jo-mueller ebc8171
tests: add writing labels to tests
jo-mueller 6effadc
feat: add labels as class attribute
jo-mueller 3429b78
tests: add tests for ingestion of image and data reading
jo-mueller 4f5749a
refactor: use image classes under the hood
jo-mueller 49ccb71
refactor: rename `dims` property to `axes` for consistency
jo-mueller 0a393ef
doc: Add image class to docs
jo-mueller 9e96c89
chore: make sure loaded image has a name that's not None
jo-mueller 242def2
feat: add `scale` argument to entrypoints
jo-mueller 8fd027c
tests: add test for writing scale w/o coordinate transformations
jo-mueller f173e88
feat: add `axes_units` kwarg to entrypoints
jo-mueller 127dfc4
enh: add backwards compatibility for reading 0.1/0.2/0.3
jo-mueller 8330ccb
enh: support omero metadata
jo-mueller 78f70bf
enh: support image-label metadata
jo-mueller 8db9822
refactor: Move image classes into submodule
jo-mueller ee90670
tests: add reader tests for new classes
jo-mueller 92ae111
tests: remove reference to v06 coordinate systems
jo-mueller 4d72e3a
feat: return delayed objects
jo-mueller 4f49ad8
fix: default to not using deprecated Scaler
jo-mueller b3892c3
enh: do not delay writing metadata
jo-mueller ee738fc
enh: pass scale and units to writer
jo-mueller c68f784
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d219470
fix: fix rebase-introduced errors
jo-mueller cc96984
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 68ffe2f
chore: use absolute imports
jo-mueller 6330cdc
chore: add coordinatetransformations deprecation warning
jo-mueller 4d76318
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] df41528
refactor: move utility functions into utils.py
jo-mueller 906c112
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 73a4c3f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fa1145d
fix: update written metadata on write
jo-mueller 3dfad13
chore: reconcile test parametrization
jo-mueller 538cd43
chore: reconcile tests
jo-mueller 062e0a4
feat: Add images to attributes that are displayed in _repr_
jo-mueller ca3133c
fix: retrieve omero metadata correctly for 0.4
jo-mueller ed8e4f9
fix: get image-label metadata from top-level attrs in 0.4
jo-mueller 2d257fa
chore: reconcile branches
jo-mueller 85d15c4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 24768d6
feat: add omero/labels handling to 0.1/0.2/0.3 ome-zarr
jo-mueller 1bcb6f5
chore: improve error message
jo-mueller 7af8ca5
tests: add test for legacy import
jo-mueller e836d4e
chore: precommit fixes
jo-mueller f23bd36
fix: do not shadow image-label writing by omero metadata
jo-mueller 164f524
feat: handle image-label/omero metadata version on write
jo-mueller 75695fd
feat: cover omero/image-label metadata in writer test
jo-mueller 5f5aa45
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4e424bd
feat: allow appending to Multiscales
jo-mueller 847cf08
tests: add tests for omero and labels metadata roundtrip
jo-mueller 15b1b5a
doc: update class import in docs
jo-mueller d576201
docs: add more docs for label handling
jo-mueller ae3d38d
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller 061271f
chore: typos
jo-mueller 50a826c
docs: Document class-based API and direct read/write side-by-side
jo-mueller 3917247
Merge branch 'master' into introduce-image-class
jo-mueller 9d532d6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 18b7618
docs: fix class API references and reran notebooks
jo-mueller 447546c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3494b73
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7066de7
Delete test.ipynb
jo-mueller 81c942b
Merge remote-tracking branch 'upstream/master' into introduce-image-c…
jo-mueller 0156fd1
fix: fix function args
jo-mueller 2b4844f
Apply suggestions from code review
jo-mueller 1cd20ac
refactor: move legacy reader in subfunction
jo-mueller 4efc92a
feat: set all fields of image classes on read
jo-mueller 31476fb
chore: consolidate import types
jo-mueller 6f873a0
feat: add test for axis/data shape missmatch
jo-mueller 4a782df
feat: allow method to be None (may be unknown on import from remote)
jo-mueller 13e9731
chore: remove duplicate code
jo-mueller 6fe665a
feat: fix label append in labels metadata
jo-mueller 0cb1a67
tests: add 0.3 with only 3 axes to test data
jo-mueller 8c4c5a5
feat: **metadata kwargs for passage of omero and image-label emtadata
jo-mueller a924e25
doc: fix 0.4 writing in docs
jo-mueller 264335d
docs: sync filename between code and markdown text
jo-mueller 53d22b8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0507c76
feat: better safeguardagainst wrong downsampling method for labels
jo-mueller 0d08149
feat: add typing to legacy function
jo-mueller b558ea7
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller 56bf8e5
chore: mypy type safety
jo-mueller 8ab91e1
feat: add setters for labels, omero and image-labels attributes
jo-mueller e9e2910
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ea02db6
refactor: Refactor into OMEZarrImage, OMEZarrMultiscale and OMEZarrLa…
jo-mueller 918cf2f
docs: Update docs
jo-mueller 1ee9609
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 175b9cb
feat: feet omero and image-label into classes for old API backwards c…
jo-mueller e0b6ab4
feat: make legacy import detect image-label, too
jo-mueller 1a9aeb6
refactor: remove references to ngff
jo-mueller f70815e
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller 1c43597
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4db6707
chore: clean debug statement in test
jo-mueller 5b51eb1
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller 1847608
fix: precommit fixes
jo-mueller 2ddd584
refactor: remove commented out old code
jo-mueller 5740332
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4172b50
chore: pre-commit fixes
jo-mueller ecc158d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6f05d85
fix: roll back bad refactor
jo-mueller df27972
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller cadc335
chore: better exception catch and typing
jo-mueller c5b68fd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b533ce2
refactor: move channels-specific kwargs into derived class
jo-mueller 594118b
feat: strengthen validation and verbosity of scale/axes/etc wrangling
jo-mueller 70f5b31
docs: improve docstrings
jo-mueller e2217a5
docs: update classes autodoc
jo-mueller 5f965a7
docs: expand parameters documented in basic write notebook
jo-mueller 0db8af6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d746027
chore: precommit fix
jo-mueller 0007494
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aec4cda
tests: add more tests for omero metadata kwargs
jo-mueller 3203e0b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d9b7202
feat: make color channel active by default
jo-mueller ab2416c
refactor: remove redundant validation block
jo-mueller 1f75eba
docs: demo more features in basic writing
jo-mueller 18feea5
refactor: remove duplicate ome-zarr-models from test deps
jo-mueller d9392f4
docs/refactor: update pyramid customization notebook
jo-mueller d560b26
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9bcb082
feat: omero version key only in 0.4
jo-mueller e02b79b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2d5b39e
feat: no hex strings
jo-mueller e36ed5e
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller 7c5143b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7a5f28e
feat: add escape for non-multiscale groups
jo-mueller ebacff7
Merge branch 'introduce-image-class' of https://github.com/jo-mueller…
jo-mueller 95a7b48
feat: allow channel metadata for single/zero channel images
jo-mueller 5b4aa53
fix: adjust dimensions written in old write function
jo-mueller 3c0f8d8
feat: hard-remove prepending #
jo-mueller 9967971
feat: remove # from color defaults
jo-mueller e7b7f06
Update docs/source/basic/write_image.ipynb
jo-mueller cd2dfdd
Update ome_zarr/classes/image.py
jo-mueller 44e1071
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 09388e7
docs: add metadata to documented attributes
jo-mueller 171ec55
docs: fix rendering of image classes
jo-mueller d9bad78
chore: used clean type check rather then assertion
jo-mueller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.