[codex] OM-SEC-21: Authenticate only after package picker code exits - #9475
Draft
AFOliveira wants to merge 10 commits into
Draft
[codex] OM-SEC-21: Authenticate only after package picker code exits#9475AFOliveira wants to merge 10 commits into
AFOliveira wants to merge 10 commits into
Conversation
AFOliveira
marked this pull request as draft
September 1, 2026 09:50
Contributor
Author
|
Reworked in f1282ad after comparing the finding with current |
…dex/portfolio-9457-20260907
# Conflicts: # bin/omarchy-security-functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package selection runs with cold sudo authorization. After discovery and the configurable picker finish, only a validated selection reaches one fixed command-scoped Pacman transaction. Finding: OM-SEC-21.
Both install/remove entrypoints now resolve their canonical shared library, validate privileged Bash startup, sanitize inherited Bash state and bind the source root before invoking configurable picker behavior. They use #9457's byte-identical foundation and revoke on completion, cancellation and failure.
Query failures are checked before starting fzf, so cancellation cannot hide a broken package query. fzf success with no selection, exit1 (no match) and exit130 (cancel) are clean no-ops; partial output from a failed/cancelled picker is discarded. Only status0 plus allowlisted package names reaches the fixed Pacman argument array. #9795/#9227's AUR review/confirmation changes are separate scope; this picker uses repository packages.
At
f5643b01, independent Daybreak final review accepts the corrections. The unprivileged orchestration fixture covers both commands' exact one-transaction success, no selection, native fzf status meanings, query/picker errors, authorization cancellation, failed transaction/revocation, source-root mismatch, inherited startup state and ordinary-Bash decoy-p rejection. CLI112, syntax and whitespace checks pass. No historical setuid/mutation model was run.Depends on #9457's coordinated shared-helper release. Interactive real fzf/Pacman smoke in the installed package stack remains an integration check; these tests establish the control flow without changing host packages.