Recover shell restarts when the replacement launch is rejected - #11014
Open
anovoselnik wants to merge 1 commit into
Open
Recover shell restarts when the replacement launch is rejected#11014anovoselnik wants to merge 1 commit into
anovoselnik wants to merge 1 commit into
Conversation
Allow a 30-second readiness window and retry the no-duplicate launch every two seconds. Cover a rejected first launch, slow startup, and the existing locked-session protections. Co-authored-by: Jacky Lam <lamchun1110@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the Dictation configuration terminal on Omarchy 4.0.3 left the bar down. The journal recorded
Exiting due to IPC request, followed five seconds later byAn instance of this configuration is already running. No core dump was recorded, and no Quickshell process remained afterward.The restart command dispatches its replacement only once. If that launch is rejected while the old instance still holds its singleton lock, readiness polling cannot bring the shell back. Retry the existing no-duplicate launch every two seconds within a 30-second readiness deadline. Keep the active lock-screen guard and stranded-lock recovery intact.
This extends the longer readiness window proposed in #8630, credited in the commit. Unlike #10634 (overlapping restart requests), it handles a rejected replacement within a single restart. The missing-Voxtype install guard is already covered by #6832 and is outside this PR.
Validation:
bash test/shell.d/restart-shell-test.sh,bash -n, andgit diff --checkpass, including active-lock preservation and stranded-lock recovery.shell ping. The original singleton-lock timing has not been deterministically reproduced on the live desktop; its failure path is exercised with stubbed launch/IPC boundaries../test/all: CLI passes; 230 of 236 shell test files pass. Six failures reproduce with the unchanged upstream restart script: config, launch-about, locate, network-qr, snapper, and unowned-system-paths. These include missing sibling packaging-checkout coverage and unrelated environment/test failures.Prepared with Codex.