Skip to content

Fix Hermes desktop installation and align menu icons - #10846

Merged
spencerbull merged 2 commits into
quattrofrom
fix-hermes-desktop-stamp-import
Sep 9, 2026
Merged

Fix Hermes desktop installation and align menu icons#10846
spencerbull merged 2 commits into
quattrofrom
fix-hermes-desktop-stamp-import

Conversation

@spencerbull

@spencerbull spencerbull commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Installing Hermes Desktop 2026.9.7 through AI → Hermes stops after copying the desktop app: _write_desktop_build_stamp moved from hermes_cli.main to hermes_cli.main_desktop, so the installer raises an ImportError before recording the build stamp and launching the app.

Import the helper from main_desktop when that module exists, retaining the old import for earlier releases. Extend the installer test with the split module layout while keeping the existing older-release cases.

Replace the snake-and-staff Hermes menu glyph with a monochrome trace of the official desktop app portrait. The existing U+E90A codepoint keeps the default-agent, install, and remove entries consistent with the installed app while retaining theme foreground and selection colors. Keep the SVG source and upstream attribution with the font. The revised font ships through an omarchy-settings release; updating the Omarchy source alone does not replace the installed font.

Companion package update: omacom/omarchy-pkgs#358. Ship this installer fix in the target Omarchy channel before publishing the new Hermes package there.

Validation: the new regression case failed before the fix; the focused installer suite and shell syntax checks pass on this branch. Independent review found no remaining issues. On the installed 2026.9.7 runtime, all 452 copied desktop files matched the package; executing the repaired installer snippet created the missing stamp, and upstream's build check confirmed the desktop was current. A complete fresh GUI installation has not been rerun since the fix.

Icon validation: the focused menu suite passes; cmap coverage and every non-Hermes glyph and metric are preserved. Independent review checked the trace against the font. Verified the actual running menu with the new glyph beside the installed Hermes app icon, with consistent sizing and theme color.

@spencerbull

Copy link
Copy Markdown
Contributor Author

Reviewed at 27f10ff with omabot's review-pr procedure. Verdict: nothing found; waiting on the maintainer.

What ran. On a disposable Omarchy worker, ./test/cli passes and test/shell.d/hermes-desktop-install-test.sh passes all 15 cases. On a second copy of the tree with only bin/omarchy-install-ai-hermes reverted to the base version, exactly the new case fails with the fixture's AssertionError, so the regression test targets the fix. Upstream Hermes was read, not executed: at the packaged commit 2237be35, _write_desktop_build_stamp(project_root, *, source_mode) is at main_desktop.py:117 and main.py no longer imports it; at 29112bef it is in main.py and main_desktop.py does not exist; upstream created that file on 2026-09-02 already carrying the helper, and no tagged release sits between the two, so the file check picks the right module for every release. The installer only reaches the snippet when the runtime is at the packaged commit, so nothing between releases is in play. No live install or launch ran.

Second opinion. Codex at xhigh found no behavioural defects and agreed on the discriminator, the test and the seed mutation order; where it agreed, its independence is not guaranteed. It added one point in favour of the design: catching ImportError instead would also mask a dependency failure inside main_desktop. Its note that the Python heredoc breaks the two-space rule is rejected: every Python heredoc on quattro uses four spaces, including this test's own.

For the maintainer. Merge order matters, as the description says: land this before omarchy-pkgs #358 publishes 2026.9.7. Anyone who installs in the window is left with the app copied and no stamp, and a re-run of the fixed installer takes the existing-app path and does not write one, so Hermes rebuilds the desktop app on first launch. Writing a missing stamp for a complete existing app would be a design change outside this PR.

Nothing pushed.

🤖 Generated by Claude Fable 5.1 in T3 Code. Reviewed by Codex XHigh.

@spencerbull spencerbull changed the title Fix Hermes desktop installation after module split Fix Hermes desktop installation and align menu icons Sep 8, 2026
@spencerbull

Copy link
Copy Markdown
Contributor Author

Re-reviewed at 1cb960a using omabot. SHIP: no defects found in the icon update. The installer and its regression test are unchanged from the previous review.

On a disposable Omarchy worker, ./test/cli passed 112 checks, hermes-desktop-install-test.sh passed 15, and menu-test.sh passed 121. FontTools comparison against the previously reviewed font confirmed unchanged character mappings, all 21 non-Hermes outlines and metrics, advance widths, and global layout metrics. The committed SVG regenerates the Hermes glyph's coordinates, contour endpoints, and flags exactly. The new font also retains the existing names and adds the portrait attribution.

I compared the old and new fonts in the running menu after replacing the worker's packaged font, refreshing its cache, and restarting the shell. The new portrait renders in Default Agent and Install → AI, with correct selection color and no clipping observed at 1280×800. The installed font's SHA-256 matched the reviewed file. I also inspected a rendered row of every private-use glyph. A fresh Hermes application install/launch was not rerun; the removal entry's unchanged glyph binding was checked in source.

GPT-6 in T3 Code performed this review and verified the worker evidence. Codex GPT-5.6 Sol at xhigh returned no static findings; its agreement is a second opinion whose independence is not guaranteed. No code changes were needed. Waiting on the maintainer: the icon still requires an omarchy-settings release, and the installer fix must reach each target channel before the corresponding Hermes package from omarchy-pkgs #358.

🤖 Generated by GPT-6 in T3 Code. Reviewed by Codex GPT-5.6 Sol XHigh.

@spencerbull
spencerbull merged commit 8ea5151 into quattro Sep 9, 2026
@spencerbull
spencerbull deleted the fix-hermes-desktop-stamp-import branch September 9, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant