Fix Hermes desktop installation and align menu icons - #10846
Conversation
|
Reviewed at 27f10ff with omabot's review-pr procedure. Verdict: nothing found; waiting on the maintainer. What ran. On a disposable Omarchy worker, Second opinion. Codex at xhigh found no behavioural defects and agreed on the discriminator, the test and the seed mutation order; where it agreed, its independence is not guaranteed. It added one point in favour of the design: catching For the maintainer. Merge order matters, as the description says: land this before omarchy-pkgs #358 publishes 2026.9.7. Anyone who installs in the window is left with the app copied and no stamp, and a re-run of the fixed installer takes the existing-app path and does not write one, so Hermes rebuilds the desktop app on first launch. Writing a missing stamp for a complete existing app would be a design change outside this PR. Nothing pushed. 🤖 Generated by Claude Fable 5.1 in T3 Code. Reviewed by Codex XHigh. |
|
Re-reviewed at 1cb960a using omabot. SHIP: no defects found in the icon update. The installer and its regression test are unchanged from the previous review. On a disposable Omarchy worker, I compared the old and new fonts in the running menu after replacing the worker's packaged font, refreshing its cache, and restarting the shell. The new portrait renders in Default Agent and Install → AI, with correct selection color and no clipping observed at 1280×800. The installed font's SHA-256 matched the reviewed file. I also inspected a rendered row of every private-use glyph. A fresh Hermes application install/launch was not rerun; the removal entry's unchanged glyph binding was checked in source. GPT-6 in T3 Code performed this review and verified the worker evidence. Codex GPT-5.6 Sol at xhigh returned no static findings; its agreement is a second opinion whose independence is not guaranteed. No code changes were needed. Waiting on the maintainer: the icon still requires an 🤖 Generated by GPT-6 in T3 Code. Reviewed by Codex GPT-5.6 Sol XHigh. |
Installing Hermes Desktop 2026.9.7 through AI → Hermes stops after copying the desktop app:
_write_desktop_build_stampmoved fromhermes_cli.maintohermes_cli.main_desktop, so the installer raises anImportErrorbefore recording the build stamp and launching the app.Import the helper from
main_desktopwhen that module exists, retaining the old import for earlier releases. Extend the installer test with the split module layout while keeping the existing older-release cases.Replace the snake-and-staff Hermes menu glyph with a monochrome trace of the official desktop app portrait. The existing U+E90A codepoint keeps the default-agent, install, and remove entries consistent with the installed app while retaining theme foreground and selection colors. Keep the SVG source and upstream attribution with the font. The revised font ships through an
omarchy-settingsrelease; updating the Omarchy source alone does not replace the installed font.Companion package update: omacom/omarchy-pkgs#358. Ship this installer fix in the target Omarchy channel before publishing the new Hermes package there.
Validation: the new regression case failed before the fix; the focused installer suite and shell syntax checks pass on this branch. Independent review found no remaining issues. On the installed 2026.9.7 runtime, all 452 copied desktop files matched the package; executing the repaired installer snippet created the missing stamp, and upstream's build check confirmed the desktop was current. A complete fresh GUI installation has not been rerun since the fix.
Icon validation: the focused menu suite passes; cmap coverage and every non-Hermes glyph and metric are preserved. Independent review checked the trace against the font. Verified the actual running menu with the new glyph beside the installed Hermes app icon, with consistent sizing and theme color.