Skip to content

Let reminders elapse during suspend #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
llirik0 wants to merge 1 commit into
base: quattro
Choose a base branch
from
+53 −2
Open

Let reminders elapse during suspend #10679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/omarchy-reminder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ fi

set_at=$(date +%s)
remind_at=$(date -d "+${minutes} minutes" +%H:%M)
deadline=$(date -u -d "+${minutes} minutes" '+%Y-%m-%d %H:%M:%S UTC')
unit="omarchy-reminder-${minutes}m-$set_at"
reminder_dir="${XDG_RUNTIME_DIR:-/tmp}/omarchy-reminders"
message_file="$reminder_dir/$unit.message"
Expand All @@ -194,7 +195,7 @@ if [[ -n $custom_message ]]; then
confirmation_title="$custom_message in ${minutes} minutes"
fi

systemd-run --user --quiet --collect --on-active="${minutes}m" --unit="$unit" \
systemd-run --user --quiet --collect --on-calendar="$deadline" --unit="$unit" \
bash -c 'omarchy-notification-send -g 󰢌 "Reminder" "$1"; rm -f "$2"; omarchy-shell -q omarchy.indicators refresh >/dev/null 2>&1 || true' bash "$message" "$message_file"

refresh_indicator
Expand Down
2 changes: 1 addition & 1 deletion docs/notifications.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ Everything goes through the same sender contract, so the pieces are small:

Reminders ride on notifications rather than being their own daemon.
`bin/omarchy-reminder <minutes> [message]` creates a transient systemd user
timer via `systemd-run --user --collect --on-active=<minutes>m` under the
timer via `systemd-run --user --collect --on-calendar=<absolute UTC deadline>` under the
unit name `omarchy-reminder-<minutes>m-<epoch>`; the timer's payload sends the
reminder toast, deletes its message file, and refreshes the bar indicator.
Custom messages are stashed in `$XDG_RUNTIME_DIR/omarchy-reminders/<unit>.message`
Expand Down
50 changes: 50 additions & 0 deletions test/shell.d/reminders-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,53 @@ assertDeepEqual(
'reminders command args are empty for invalid minutes'
)
JS

test_dir=$(mktemp -d)
trap 'rm -rf "$test_dir"' EXIT
mkdir -p "$test_dir/bin" "$test_dir/runtime"

cat >"$test_dir/bin/date" <<'EOF'
#!/bin/bash
case "$*" in
"+%s") echo 1788804000 ;;
"-d +7 minutes +%H:%M") echo 11:07 ;;
"-u -d +7 minutes +%Y-%m-%d %H:%M:%S UTC") echo "2026-09-07 18:07:00 UTC" ;;
*) exit 1 ;;
esac
EOF

cat >"$test_dir/bin/systemd-run" <<'EOF'
#!/bin/bash
printf '%s\n' "$@" >"$TEST_LOG"
EOF

for command in omarchy-notification-send omarchy-shell; do
cat >"$test_dir/bin/$command" <<'EOF'
#!/bin/bash
exit 0
EOF
chmod +x "$test_dir/bin/$command"
done
chmod +x "$test_dir/bin/date" "$test_dir/bin/systemd-run"

TEST_LOG="$test_dir/systemd-run.log" \
XDG_RUNTIME_DIR="$test_dir/runtime" \
PATH="$test_dir/bin:$PATH" \
bash "$ROOT/bin/omarchy-reminder" 7 "Tea ready"

grep -Fxq -- '--on-calendar=2026-09-07 18:07:00 UTC' "$test_dir/systemd-run.log" ||
fail "reminder deadline uses wall-clock time" "systemd-run did not receive the absolute reminder deadline"
pass "reminder deadline uses wall-clock time"

if grep -q '^--on-active=' "$test_dir/systemd-run.log"; then
fail "reminder avoids an active-time delay" "$(<"$test_dir/systemd-run.log")"
fi
pass "reminder avoids an active-time delay"

grep -Fxq -- '--unit=omarchy-reminder-7m-1788804000' "$test_dir/systemd-run.log" ||
fail "reminder keeps its unit naming" "$(<"$test_dir/systemd-run.log")"
pass "reminder keeps its unit naming"

[[ $(<"$test_dir/runtime/omarchy-reminders/omarchy-reminder-7m-1788804000.message") == "Tea ready" ]] ||
fail "reminder keeps its custom message file"
pass "reminder keeps its custom message file"