Guard SDDM theme selection against Qt5 greeter incompatibility - #10663
Open
surim0n wants to merge 1 commit into
Open
Guard SDDM theme selection against Qt5 greeter incompatibility#10663surim0n wants to merge 1 commit into
surim0n wants to merge 1 commit into
Conversation
Fresh Omarchy 4.x has no Qt5 packages. SDDM falls back to the Qt5 greeter (/usr/bin/sddm-greeter) for any theme whose metadata.desktop does not declare QtVersion=6. On a 4.x install that leaves the login screen permanently black. Add a migration that, on update, detects when the active SDDM theme is not Qt6 and the Qt5 greeter cannot run (missing shared libraries), then resets Current= back to the packaged omarchy theme. - migrations/1788380505.sh: the guard - test/shell.d/sddm-qt6-guard-test.sh: coverage for safe, unsafe, runnable-Qt5, custom-Qt6, and no-theme cases Fixes omacom#10302. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh Omarchy 4.x has no Qt5 packages. SDDM falls back to the Qt5 greeter (
/usr/bin/sddm-greeter) for any theme whosemetadata.desktopdoes not declareQtVersion=6. On a 4.x install that leaves the login screen permanently black.Fixes #10302.
Change
migrations/1788380505.sh, run byomarchy update/omarchy-migrate./etc/sddm.confand/etc/sddm.conf.d/*.confin SDDM load order to find the activeCurrent=theme.metadata.desktopdoes not declareQtVersion=6and the Qt5 greeter is missing shared libraries, it resets the activeCurrent=line toomarchyand reports the change.Test plan
bash test/shell.d/sddm-qt6-guard-test.shpassesbash test/shell.d/systemd-test.shstill passesgit diff --checkcleanCurrent=mayain/etc/sddm.conf.d/99-theme.conf, runomarchy-migrate, confirm it resets toomarchy.Generated with Devin