[codex] Revoke passwordless grants when settings is removed - #257
Draft
AFOliveira wants to merge 5 commits into
Draft
[codex] Revoke passwordless grants when settings is removed#257AFOliveira wants to merge 5 commits into
AFOliveira wants to merge 5 commits into
Conversation
AFOliveira
marked this pull request as draft
September 5, 2026 13:22
AFOliveira
force-pushed
the
codex/om-sec-01-passwordless-package-cleanup
branch
from
September 7, 2026 21:46
1545a9b to
84806c5
Compare
AFOliveira
changed the base branch from
fix/package-owned-system-hooks
to
master
September 7, 2026 21:51
This was referenced Sep 7, 2026
Member
|
LGTM - pending 9457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings owns the complete temporary sudo-grant lifecycle: publication helper, shared security library, boot cleanup and an aborting pre-transaction revocation hook. Removing only the desktop runtime preserves expiry support; upgrading or removing settings revokes the grant before those files disappear.
The hook and grant publication share one lock and a package-transition marker. Revocation failure aborts the ALPM transaction and blocks new grants until a successful retry. Scriptlets retain the legacy fallback for the first upgrade from packages without the hook; scriptlet errors are not claimed to abort that transaction.
Companion: Omarchy #9457. Current integration
b787991resolves the conflict against masterb3c1ef8, preserves its4.0.3rc1source pin/checksum, and advances both release packages to4.0.3rc1-3. Runtime requires the exact full version-release of its matching settings package in both channels. #239 is separate overlapping ownership work, not a required parent.Still draft: the declared upstream source
7cc90574predates #9457 and cannot build these settings recipes. After #9457 lands, advance both release pins and checksums together to the real upstream commit containing it, build the declared sources, and publish each matching pair together. The current pin must not be released. No fork revision or duplicate backport has been substituted for that upstream prerequisite.Daybreak independently reviewed
b787991with source60ac419f, verified all four x86_64 archive hashes, exclusive lifecycle ownership and exact pair dependencies, and found no new package-code blocker. Settings builds used normal dependency checks. Runtime builds usedmakepkg --nodeps; actual matched-pair installation in the disposable VM then checked their dependencies. Reinstall, stable/dev transfers, runtime/settings removal, aborting removal on a benign revocation error, and successful recovery all passed. The VM was restored afterward.These builds used the explicit candidate
OMARCHY_SRCoverride and do not validate the declared release pin. Four aarch64 payloads were also built on x86_64 and checked for architecture-specific contents/dependencies and exact lifecycle-file bytes; native ARM runtime and fresh-ISO validation remain untested.