Skip to content

Update the tool type for inference span to generic tool.function in o… #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasad-okahu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the tool type for inference span to generic tool.function in o… #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apptrace/src/monocle_apptrace/instrumentation/metamodel/openai/_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
map_openai_finish_reason_to_finish_type,
OPENAI_FINISH_REASON_MAPPING
)
from monocle_apptrace.instrumentation.common.constants import AGENT_PREFIX_KEY, INFERENCE_AGENT_DELEGATION, INFERENCE_TURN_END, INFERENCE_TOOL_CALL
from monocle_apptrace.instrumentation.common.constants import AGENT_PREFIX_KEY, INFERENCE_AGENT_DELEGATION, INFERENCE_TURN_END, INFERENCE_TOOL_CALL, TOOL_TYPE
from contextlib import suppress

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -427,7 +427,7 @@ def extract_tool_type(arguments):
tool_call = _get_first_tool_call(response)
if tool_call:
# Return generic tool type for OpenAI tools
return "tool.openai"
return TOOL_TYPE

except Exception as e:
logger.warning("Warning: Error occurred in extract_tool_type: %s", str(e))
Expand Down
2 changes: 1 addition & 1 deletion apptrace/tests/integration/test_openai_finish_reason_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def test_finish_reason_function_call(setup):
assert "entity.3.name" in span_attributes, "entity.3.name should be present when finish_type is tool_call"
assert "entity.3.type" in span_attributes, "entity.3.type should be present when finish_type is tool_call"
assert span_attributes["entity.3.name"] == "get_current_weather", f"Expected tool name 'get_current_weather', got '{span_attributes.get('entity.3.name')}'"
assert span_attributes["entity.3.type"] == "tool.openai", f"Expected tool type 'tool.openai', got '{span_attributes.get('entity.3.type')}'"
assert span_attributes["entity.3.type"] == "tool.function", f"Expected tool type 'tool.function', got '{span_attributes.get('entity.3.type')}'"


if __name__ == "__main__":
Expand Down
Loading