fix(standby): re-check local_append_enabled_ inside the append critical section to close a promotion-fence race - #1326
Open
footka wants to merge 1 commit into
Open
fix(standby): re-check local_append_enabled_ inside the append critical section to close a promotion-fence race#1326footka wants to merge 1 commit into
footka wants to merge 1 commit into
Conversation
…al section to close a promotion-fence race When SWITCHOVER TO STANDBY lands during the MAJOR MERGE medium_info submission burst, the entry check in append (local_append_enabled_) and the actual submit in append_'s CriticalGuard(ls_qs_) are not atomic fence_local_append_ (set_local_append_enabled(false) + WaitQuiescent(ls_qs_)) cannot stop a caller that already passed the entry check but has not yet entered the critical section. Such a submission lands after the fence advancing end_scn past the cutover_scn captured by prepare_to_standby which then trips the durably-fenced check and fails SWITCHOVER TO PRIMARY with 4109 (OB_STATE_NOT_MATCH). Fix: re-check local_append_enabled_ inside the critical section (double- checked locking). 1.3 is unaffected: fence_local_append / local_append_enabled_ were introduced in 1.4.
Member
Author
|
The mapping Dima issue is: "[seekdb][standby] In version 1.4, the primary promotion fence does not cover the internal commit channel for merges: during a peak of merge commits, a SWITCHOVER to promote to primary occasionally results in error 4109." |
hnwyllmm
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Solution Description
Passed Regressions
Upgrade Compatibility
Other Information
Release Note