Stop the installation process via .install file from creating unnecessary intermediate directories for paths that contain '..' - #7015
Merged
kit-ty-kate merged 2 commits intoJul 17, 2026
Conversation
kit-ty-kate
force-pushed
the
no-install-intermediate-dir
branch
from
July 14, 2026 19:18
6b862b5 to
07cde75
Compare
rjbou
added
the
PR: QUEUED
rjbou
reviewed
Jul 15, 2026
rjbou
left a comment
rjbou
left a comment
Collaborator
There was a problem hiding this comment.
Same, the main comment and main commit (last one) doesn't contains the explanation of what was done to no longer create intermediate dirs during the installation process from .install.
…ing '..' in .install files
…sary intermediate directories for paths that contain '..' The target path is now resolved before creation
rjbou
force-pushed
the
no-install-intermediate-dir
branch
from
July 17, 2026 17:53
07cde75 to
eb8bbda
Compare
rjbou
approved these changes
Jul 17, 2026
rjbou
left a comment
rjbou
left a comment
Collaborator
There was a problem hiding this comment.
Updated commit msg & main comment
rjbou
added
STATE: READY TO MERGE
and removed
PR: QUEUED
Member
Author
|
Ignoring the missing macOS runs. Seems like GitHub have nuked their macOS machines out of existence |
Member
Author
|
The effect of the change can be seen in #7008 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected in #7008
Target paths are now resolve before their creation & install.
Backported to 2.5 in #7009
It is queued on #7008 (reintroduce '..') to be able to see the changes in tests, but #7008 can't be merged without this PR. So #7008 contains the update of the test added here