Make OpamFilename.remove_prefix consistent with starts_with - #7004
Draft
kit-ty-kate wants to merge 1 commit into
Draft
Make OpamFilename.remove_prefix consistent with starts_with#7004kit-ty-kate wants to merge 1 commit into
kit-ty-kate wants to merge 1 commit into
Conversation
Member
Author
|
In my opinion, i think we should rather focus on #6986 and find good invariants in the first place than finish this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #6953 by @NathanReb
In my opinion the change is too impacting (e.g. #6625) and not as easy to check the correctness of. Also tests were missing and the original issue isn't present on
remove_prefix.