Configure zarith and gmp with pkg-config on macOS with homebrew/macports - #22954
Configure zarith and gmp with pkg-config on macOS with homebrew/macports#22954artempyanykh wants to merge 4 commits into
Conversation
|
Thanks for the review @mseri! I extracted changes as naw package versions. |
artempyanykh
changed the title
b7627f3 to
c4e015d
Compare
|
rebase |
c4e015d to
33cb234
Compare
|
rebase |
1. This makes conf-gmp behave similarly to other conf-* packages that use pkg-config. 2. This works when homebrew is installed in a custom location.
Benefits: 1. Works fine when brew is installed in a custom location. 2. Can use the same command-line for x64 and aarch64 macOS.
Also, add macports
33cb234 to
5d948aa
Compare
|
rebase |
|
@mseri what is the usual process here? There are failures on CI but they don't seem to be related to the change in this PR. |
|
changes in gmp may have hidden repercussions on other packages, I need to check them, add some upper bounds and then make the new release. It is basically pending on actions from may part, sorry. I have been very busy in the past two weeks and, unfortunately, will be for one more week. After that this will be my priority |
|
@mseri thank you! Didn't intend to push. I was mainly interested if there's something on my end that needs to be done. |
See ocaml#18129 and ocaml#22954 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
|
I have opened a draft PR with a simplified update on the same lines |
|
Hi @artempyanykh, thanks for the ping. I have done it on purpose, to check the breakage. I already have the change locally, will push it after having finished evaluating the CI failures |
See ocaml#18129 and ocaml#22954 Signed-off-by: Marcello Seri <marcello.seri@gmail.com> Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
2 participants
Benefits:
I did some local testing on