Make paths from ld.conf absolute - #119
Closed
rlepigre-skylabs-ai wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for this - you're right that the normalisation is technically a problem for the detection which findlib does when updating ld.conf (not that that is a very common way to use findlib these days, I think - opam, in particular, is not configured that way). There's a commit in #122 which does both this, and the normalisation. |
Contributor
Author
|
OK, thanks. Should we just close this PR then? |
Member
|
Closing in favour of implementation in #122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #115 by making relative paths contained in a read
ld.conffile absolute (by making them relative to the directory holding theld.conffile). This is necessary for reading theld.conffile that is installed by OCaml 5.5.0, which on current opam switch contains:Note however that this will lead to the following paths with this PR, since no normalization is performed.
I believe this could have implications for parts of the system that deal with installing / uninstalling packages, but it could well be that things are fine if the paths are always consistent. In any case, I'm not sure the install/uninstall features are widely used now that most packages rely on dune.