Emit the rounding instructions for Float.round, Float.trunc, ceil and floor on arm64 and power - #15017
Open
Zaneham wants to merge 4 commits into
Open
Emit the rounding instructions for Float.round, Float.trunc, ceil and floor on arm64 and power#15017Zaneham wants to merge 4 commits into
Zaneham wants to merge 4 commits into
Conversation
miodvallat
approved these changes
Aug 24, 2026
Contributor
|
Please update Changes entry and we can merge. Thanks! |
Contributor
Author
|
Done! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Float.round, Float.trunc, ceil and floor went out to C everywhere, though arm64
and power have had one instruction for each since ARMv8-A and ISA 2.02. Eight
calls become eight instructions.
riscv needs Zfa and s390x needs z196 for the form that doesn't raise inexact,
so I can't do both, GCC does the same thing.
Tested on cfarm185 and cfarm120.