-
Notifications
You must be signed in to change notification settings - Fork 386
chore: Adopt Dune Package Management for the OCaml.org Build #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sabine
wants to merge
59
commits into
main
Choose a base branch
from
dune_pkg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
9890983
chore: migrate to using dune package management
sabine 052da15
make Dockerfile use Dune Developer Preview to build
sabine d012918
update Makefile to use Dune Developer Preview
sabine 056143a
remove .opam files
sabine 03ed5cb
update HACKING.md for dune pkg, CONTRIBUTING.md doesn't need updating
sabine e9add8b
attempt to make Playground build with Dune Developer Preview (fails)
sabine f2a124d
Build playground with dune pkg
Sudha247 1f81110
update CI to use Dune Developer Preview
sabine 5310706
update scraper workflow to use dev preview
sabine 3c1d0a7
copy playground cmi files
sabine f5efbab
update playground gitignore
sabine 7a26498
remove opam.locked file
sabine f4b7c91
rely on dune.lock
sabine 3074548
remove obsolete config
sabine 636a588
build scraper in makefile
sabine 18c5973
rely on dune.lock
sabine 490181a
Pin dune pkg to a specific version in the Dockerfile
Sudha247 87cb879
update Dockerfile and HACKING.md
Sudha247 87c681c
revert accidental playground changes
sabine 2cf37c1
Update to use Dune binary
Sudha247 0ba1af7
Address review comments
Sudha247 b180e20
add ocamlformat as a test dependency
Sudha247 dc83438
remove river pin
sabine 47b01d1
reduce changes to playground dune-project
sabine 2e17363
update README.md and HACKING.md
sabine b3fd1d9
update workflows to use Dune 3.19.1 binary
sabine ab45fb5
add a workflow to build every day using Dune Developer Preview
sabine 3d372ed
remove unnecessary compiler version parameter from workflows
sabine c927ae8
Update Dockerfile @gridbugs
sabine b16de58
update workflows to use ocaml-dune/setup-dune@v1
sabine 2d22624
update contributor docs to mention opam-repository pin upgrade process
sabine f6b377c
add a note for contributors for troubleshooting build issue after rebase
sabine 776e0a2
be more precise
sabine d50b14b
Fix make clean, add make wipe
cuihtlauac 9125e06
Update Dockerfile
sabine 7c92a48
Update Dockerfile
sabine b5731d4
Update Dockerfile
sabine 269508d
Apply suggestion from @MisterDA
sabine c99a3d1
Apply suggestion from @MisterDA
sabine 34076cd
Update playground/dune to use `ocaml-config` instead of `ocamlopt`
sabine 64ec3f9
Update Dockerfile
sabine a19a329
use 'latest' version of Dune
sabine 5d7eae3
Update Dockerfile to use alpine:3.22
sabine 433b700
update maintainer docs to reflect Dockerfile not pinning opam-repository
sabine a07f4ea
use dune 3.20.1 again because 'latest' is not downloadable via the sh…
sabine 348ab34
add announcement post about this migration
sabine aca8154
use --network=host on docker build command in Makefile
sabine e907f4f
corrections to the included OCaml Backstage post
sabine de1e62f
rename
sabine b9eee75
update playground/dune-workspace to also rely on overlay repository
sabine bda6f03
Fix playground build by properly resolving jsoo_listunits path
sabine 945a19c
Fix markdown linting error in Dune package management blog post
sabine d18e313
correct a comment in Dockerfile
sabine a2ff129
address @MisterDA review from 2 weeks ago
sabine 31b7fdb
remaining Oct 3 review changes from @MisterDA review
sabine 26d592c
had to add back -s 3.20.1 on the Dune installation in Dockerfile beca…
sabine 89545d6
correct invocation of Dune install script to use the latest stable ve…
sabine 3b2139b
use latest stable version of dune in all CI actions
sabine d2b11f8
upgrade to alpine:3.22 on the container to be deployed
sabine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| !tool/ | ||
| !dune | ||
| !dune-project | ||
| !ocamlorg.opam | ||
| !dune-workspace | ||
| !tailwind.config.js | ||
| !init-cache | ||
| !.git | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.