fix(rename): expand record puns - #2065
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
Use Merlin's recovered parsetree to distinguish punned record expressions and patterns from ordinary identifier occurrences. When renaming a variable, preserve the field and insert an explicit assignment. When renaming the field itself, preserve the variable on the right-hand side. Cover expression puns, pattern puns, and field renames through full workspace-edit snapshots. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-zroqnnuoxosk
branch
from
July 31, 2026 22:15
891455c to
783925c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Merlin's recovered parsetree to distinguish punned record expressions and patterns from ordinary identifier occurrences.
When renaming a variable, preserve the field and insert an explicit assignment. When renaming the field itself, preserve the variable on the right-hand side. Cover expression puns, pattern puns, and field renames through full workspace-edit snapshots.