fix(code-actions): reject cross-line destruct recovery - #2063
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-yxmptsysytku
branch
from
July 31, 2026 22:34
fab3201 to
ca612f0
Compare
Destruct-line offsets are relative to the queried line. Decline Merlin replies whose replacement location escapes that line instead of shifting an unrelated source position. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-yxmptsysytku
branch
from
July 31, 2026 23:18
ca612f0 to
ac76305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destruct-line computes preprocessing offsets relative to the queried source line. Applying those offsets to a Merlin recovery location beginning on another line can move the edit endpoint into the middle of a UTF-8 scalar and can also target unrelated source.
Allow destruct post-processing to reject unusable replies and return no destruct-line action when either recovered endpoint escapes the query line.