fix(rename): keep occurrence conversion on one snapshot - #2062
Open
rgrinberg wants to merge 1 commit into
Open
Conversation
rgrinberg
force-pushed
the
push-plslpusmqnnp
branch
from
July 31, 2026 22:33
0e39e55 to
1665076
Compare
Snapshot all open documents before querying Merlin, then use those same sources and versions to convert the returned occurrence locations. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-plslpusmqnnp
branch
from
July 31, 2026 23:18
1665076 to
1e8bd9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename queried Merlin using one document snapshot but later converted the returned locations and selected document versions from the mutable store. A concurrent
didChangecould therefore combine old occurrence offsets with newer source and raiseInvalid_argument("index out of bounds").Snapshot all open documents before dispatching the query and use those sources and versions consistently when constructing the workspace edit.