fix(code-actions): reject malformed destruct-line replies - #2043
Open
rgrinberg wants to merge 1 commit into
Open
fix(code-actions): reject malformed destruct-line replies#2043rgrinberg wants to merge 1 commit into
rgrinberg wants to merge 1 commit into
Conversation
rgrinberg
force-pushed
the
push-wsqrtopztuxp
branch
from
July 31, 2026 21:43
ff085bf to
87953d1
Compare
rgrinberg
changed the title
rgrinberg
force-pushed
the
push-wsqrtopztuxp
branch
from
July 31, 2026 22:32
87953d1 to
cc55e9d
Compare
Let destruct post-processing decline recovery results and return no action when a match-line reply does not contain the expected with separator. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-wsqrtopztuxp
branch
from
July 31, 2026 23:18
cc55e9d to
2a6866e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery parsing can recognize
match xwithas a match expression even though the destruct reply does not contain the standalonewithseparator required by destruct-line formatting. The previous exception-raising substring lookup escaped as a JSON-RPC internal error.Allow destruct post-processing to reject unusable recovery results. Destruct-line now returns no action for this case while ordinary destruct actions remain unchanged.