Fix locate when cursor is on another declaration - #2118
Open
aryemans wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2033.
When
locateis invoked with an explicit identifier while the cursor is on a different declaration, context detection currently treats the cursor position as the definition point and returnsAlready at definition point.This changes declaration context detection so that it only reports being at the origin when the declaration under the cursor has the same name as the requested identifier. Otherwise, lookup continues normally.
The fix covers value and type declarations and adds a regression test for the reported case.
Tests:
dune runtest tests/test-dirs/locate/issue2033.tdune build @all-locate-testsdune runtest