Skip to content

Add OneNote page date property option #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keilogic wants to merge 1 commit into from
Closed

Add OneNote page date property option #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/formats/onenote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { OnenotePage, SectionGroup, User, PublicError, Notebook, OnenoteSection } from '@microsoft/microsoft-graph-types';
import { DataWriteOptions, Notice, Setting, TFolder, htmlToMarkdown, ObsidianProtocolData, requestUrl, moment } from 'obsidian';
import { DataWriteOptions, Notice, Setting, TFile, TFolder, htmlToMarkdown, ObsidianProtocolData, requestUrl, moment } from 'obsidian';
import { genUid, extractErrorMessage, parseHTML, sanitizeFileName } from '../util';
import { FormatImporter } from '../format-importer';
import { ATTACHMENT_EXTS, AUTH_REDIRECT_URI, ImportContext } from '../main';
Expand Down Expand Up @@ -64,6 +64,7 @@ export class OneNoteImporter extends FormatImporter {
// Settings
importPreviouslyImported: boolean = false;
importIncompatibleAttachments: boolean = false;
addPageDatesAsProperties: boolean = false;
// UI
microsoftAccountSetting: Setting;
switchUserSetting: Setting;
Expand Down Expand Up @@ -100,6 +101,14 @@ export class OneNoteImporter extends FormatImporter {
.onChange((value) => (this.importPreviouslyImported = !value))
);

new Setting(this.modal.contentEl)
.setName('Add page dates as properties')
.setDesc('Adds the OneNote page created and last modified timestamps to each imported note as Obsidian properties.')
.addToggle((toggle) => toggle
.setValue(false)
.onChange((value) => (this.addPageDatesAsProperties = value))
);

let authenticated = false;
if (this.retrieveRefreshToken()) {
try {
Expand Down Expand Up @@ -594,6 +603,9 @@ export class OneNoteImporter extends FormatImporter {
ctime: created ?? lastModified ?? Date.now(),
mtime: lastModified ?? created ?? Date.now(),
};
if (this.addPageDatesAsProperties) {
await this.addPageDateProperties(fileRef, page);
}
await this.vault.append(fileRef, '', writeOptions);
progress.reportNoteSuccess(page.title!);
}
Expand All @@ -602,6 +614,17 @@ export class OneNoteImporter extends FormatImporter {
}
}

async addPageDateProperties(file: TFile, page: OnenotePage): Promise<void> {
await this.app.fileManager.processFrontMatter(file, (frontmatter) => {
if (page.createdDateTime) {
frontmatter['created'] = moment(page.createdDateTime).toISOString();
}
if (page.lastModifiedDateTime) {
frontmatter['modified'] = moment(page.lastModifiedDateTime).toISOString();
}
});
}

/** Convert MathML elements to LaTeX format for Obsidian */
convertMathML(pageElement: HTMLElement): void {
const mathElements = Array.from(pageElement.querySelectorAll('math'));
Expand Down