Repository navigation
fix: wait for instance configured on test vmcp launch before navigating - #8265
Merged
ivyjeong13 merged 2 commits intoOct 15, 2026
Conversation
ivyjeong13
force-pushed
the
fix/wait-for-configured-instances-before-navigating-to-inspector
branch
from
October 14, 2026 18:00
9ec4ac7 to
70fe89e
Compare
ivyjeong13
marked this pull request as ready for review
October 14, 2026 18:00
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The polling predicate contradicts the new tests, and successful launch can leave stale local configuration status.
2 open findings
What changed in this PR
This PR aims to prevent the configuration-update prompt from briefly appearing during Test vMCP setup, addressing #7974.
Changes:
- Poll instance configuration status during connection setup.
- Keep the inspector loading while an unconfigured instance is being refreshed.
- Add regression tests and update launch mocks.
| File | Description |
|---|---|
| ui/user/src/lib/services/user/types.ts | Add the configuration-check hash field. |
| ui/user/src/lib/components/vmcps/VMcpTester.svelte.spec.ts | Test loading-state behavior. |
| ui/user/src/lib/components/vmcps/VMcpTester.svelte | Adjust inspector loading conditions. |
| ui/user/src/lib/components/vmcps/VMcpDesigner.svelte.spec.ts | Mock instance-status retrieval. |
| ui/user/src/lib/components/vmcps/ConnectVMcp.svelte.spec.ts | Test configuration polling and navigation. |
| ui/user/src/lib/components/vmcps/ConnectVMcp.svelte | Replace optimistic configuration with polling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ivyjeong13
force-pushed
the
fix/wait-for-configured-instances-before-navigating-to-inspector
branch
from
October 14, 2026 18:36
70fe89e to
cb7482a
Compare
ivyjeong13
requested review from
calvinmclean,
cjellick,
g-linville,
njhale and
thedadams
October 14, 2026 22:44
calvinmclean
approved these changes
Oct 14, 2026
thedadams
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the user briefly seeing component configuration update is needed after having already successfully launching through the connect/launch flow for Test vMCP; the flow has been updated to, after successfull launch, poll and make sure the instance has configured = true before navigating to the vmcp inspector.
Addresses #7974