Skip to content

fix(#6669): atomize the auto-name before the fold checks #6672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangjj-iso wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#6669): atomize the auto-name before the fold checks #6672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion eo-printer/src/main/resources/org/eolang/printer/print/inline-cactoos.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,21 @@
never moved its value anywhere: dropping it deletes the declaration from the
printed source, so a private helper formation or const cache that nothing
reads yet would silently vanish (#5914).

The name is atomized once here, before any of those functions is asked
(#6669). Each declares its `$name` as `xs:string`, so handing over the
`@name` node left the conversion to the function conversion rules, and Saxon
is free to bind the parameter to a closure over the argument expression
rather than over its converted value. The node then arrives inside the
function, where `eo:resolved-name(@base) = $name` has already been compiled
to a `ValueComparison` on the strength of the declared types — it casts
straight to `AtomicValue` and the sheet dies with "DOMNodeWrapper cannot be
cast to AtomicValue". A string leaves the conversion with nothing to lose,
as at the `eo:signature` call in "to-eo-tree".
-->
<xsl:template match="o[starts-with(@name, $auto) and not(eo:void(.))]" priority="1">
<xsl:if test="eo:recursive(., @name) or eo:dispatched(., @name) or eo:vertical-const(.) or eo:unreferenced(., @name) or (eo:multi-referenced(., @name) and eo:rebuilt(.)) or eo:piped(., @name) or eo:arg-applied(., @name) or eo:nested-applied(., @name) or eo:reapplied(., @name)">
<xsl:variable name="name" as="xs:string" select="string(@name)"/>
<xsl:if test="eo:recursive(., $name) or eo:dispatched(., $name) or eo:vertical-const(.) or eo:unreferenced(., $name) or (eo:multi-referenced(., $name) and eo:rebuilt(.)) or eo:piped(., $name) or eo:arg-applied(., $name) or eo:nested-applied(., $name) or eo:reapplied(., $name)">
<xsl:copy>
<xsl:apply-templates select="node()|@*"/>
</xsl:copy>
Expand Down
Loading