`embark-act` with `prefix-help-command`

[jvillasante]

I'm using embark-act (bound to C-;) as a replacement for which-key as explained here: https://www.matem.unam.mx/~omar/apropos-emacs.html#the-case-against-which-key-a-polemic

The issue I'm having is that, after pressing <prefix> C-h to see all the candidates I have to press C-; twice to act on those candidates. The first time I press C-;, Emacs shows [No cycling possible; press C-; again to act.] and I have to press it a second time for it to work.

Embark is installed as follows:

(use-package embark
    :init (setq prefix-help-command #'embark-prefix-help-command))

[oantolin]

Oh, I hadn't come across this bug before because I set embark-cycle-key to . (because I bind embark-act to C-., but don't want to use modifiers when I cycle). This bug only occurs with the default value of embark-cycle-key of nil (which means you cycle with the same key as with which you act). I'll think about how to fix this, it shouldn't be too hard.

[minad]

I think we already knew about this problem when we added cycling, see the comment:

embark/embark.el

Lines 1481 to 1486 in 7b3b2fa

	;; Rebind `embark-cycle' in order allow cycling
	;; from the `completing-read' prompter. Additionally
	;; `embark-cycle' can be selected via
	;; `completing-read'. The downside is that this breaks
	;; recursively acting on the candidates of type
	;; embark-keybinding in the `completing-read' prompter.