[RHELC-1511] Tell users to use config ini instead of env vars - #1433
Merged
danmyway merged 1 commit intoNov 27, 2024
Merged
Conversation
bocekm
added
skip/changelog
Member
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 20, 2024 23:37
2b03ee6 to
20c620c
Compare
Member
|
/packit test |
bocekm
changed the title
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 21, 2024 19:50
9a90f0d to
e235cbd
Compare
Member
|
/packit test |
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 22, 2024 14:44
58b50cd to
b737455
Compare
bocekm
marked this pull request as ready for review
November 22, 2024 14:44
bocekm
commented
Nov 22, 2024
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 22, 2024 15:43
68e08e4 to
913b709
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 96.09% 96.09% -0.01%
==========================================
Files 72 72
Lines 5143 5142 -1
Branches 888 888
==========================================
- Hits 4942 4941 -1
Misses 119 119
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
I can split this up into necessary-only changes and nice to have formatting changes so that there's not that many changes to review at once. |
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 25, 2024 21:53
3619535 to
b0e1b95
Compare
Member
Author
|
Ok, I have slashed the number of changed lines to a third, keeping just the bare minimum. I'll create another PR for the nice-to-have changes to the messages. |
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
2 times, most recently
from
November 26, 2024 16:45
0db29cc to
34af479
Compare
bocekm
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 26, 2024 17:55
34af479 to
539280d
Compare
Member
|
/packit test |
bocekm
added
tests/tier0
Member
Env vars have been deprecated in favor of the ini config file (e.g. /etc/convert2rhel.ini). for that reason We should be telling users to use the config file instead of the deprecated env vars.
danmyway
force-pushed
the
messages-to-tell-to-use-config-not-env-vars
branch
from
November 27, 2024 10:32
539280d to
3caee03
Compare
Member
|
/packit test |
danmyway
approved these changes
Nov 27, 2024
danmyway
left a comment
danmyway
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for taking care of the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Env vars have been deprecated in favor of the ini config file (e.g. /etc/convert2rhel.ini). We should be telling users to use the config file instead of the deprecated env vars.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant