webadmin: trim OVA path before submit on import dialog - #1144
Merged
Conversation
- pasted paths with leading/trailing whitespace were sent verbatim, causing FileNotFoundError from the ovirt-ova-query ansible role - trim at the model boundary (ImportVmsModel + ImportTemplatesModel) so user input never reaches the engine with whitespace - null-safe; null paths still pass through unchanged Signed-off-by: Ryan Ronnander <rronnander@linbit.com>
ryan-ronnander
force-pushed
the
linbit/mbs-ova-path-trim
branch
from
May 5, 2026 23:27
2155b01 to
844ab68
Compare
JasperB-TeamBlue
self-requested a review
May 7, 2026 14:23
JasperB-TeamBlue
approved these changes
May 7, 2026
JasperB-TeamBlue
left a comment
JasperB-TeamBlue
left a comment
Collaborator
There was a problem hiding this comment.
Small but good fix, tested it out and LGTM.
Collaborator
|
/ost |
|
⏳ Running ost suite 'basic-suite-master' on distro 'centos9'. Follow the progress here. |
|
😎💪 ost suite 'basic-suite-master' on distro 'centos9' finished successfully. (details) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1143 - Discovered while testing the upstream MBS feature push (#1138, #1133, #1125, oVirt/vdsm#459). The bug itself is not MBS-specific. Affects any OVA import.
Changes introduced with this PR
ImportVmsModel: trim the OVA path before passing tosetIsoNameImportTemplatesModel: same trim before passing tosetIsoNameAre you the owner of the code you are sending in, or do you have permission of the owner?
Yes