Skip to content

packaging/setup: remove defunct glance repo - #1132

Merged
dupondje merged 1 commit into
oVirt:masterfrom
sp-viktori:remove-glance-setup
Mar 26, 2026
Merged

packaging/setup: remove defunct glance repo#1132
dupondje merged 1 commit into
oVirt:masterfrom
sp-viktori:remove-glance-setup

Conversation

@sp-viktori

Copy link
Copy Markdown
Contributor

Remove the set up of the defunct Glance image repo at glance.ovirt.org.

Changes introduced with this PR

  • Remove the setup plugin that adds the now-defunct glance.ovirt.org image repository.

Are you the owner of the code you are sending in, or do you have permission of the owner?

Yes

Remove the set up of the defunct Glance image repo at glance.ovirt.org.

Signed-off-by: Viktor Ivanov <viktor.ivanov@storpool.com>
@sp-viktori
sp-viktori force-pushed the remove-glance-setup branch from e31df19 to 4a9905f Compare March 25, 2026 14:02
@dupondje

Copy link
Copy Markdown
Member

Nice catch, thanks!

@dupondje
dupondje merged commit 81eb855 into oVirt:master Mar 26, 2026
3 checks passed
@dupondje

Copy link
Copy Markdown
Member

@sp-viktori : Just something I think of.
What happens on upgrade? I think we should have something on upgrade that also removes the glance repo.

@sp-viktori

Copy link
Copy Markdown
Contributor Author

@sp-viktori : Just something I think of. What happens on upgrade? I think we should have something on upgrade that also removes the glance repo.

True, should also remove it, maybe with an SQL migration instead of a setup plugin? The setup was via inst_add_glance_provider with specific fixed values so I'm thinking to add delete queries for those exact values. I need to check if any images the system would have gotten from that Glance repo retain some references that should not be broken though (i.e. if we need to do some checks first and keep the domain up on some systems).

@sp-viktori

Copy link
Copy Markdown
Contributor Author

Created follow-up PR #1136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants