Skip to content

webadmin: fix template creation resource issues #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zabdulre wants to merge 1 commit into
base: master
Choose a base branch
from
Open

webadmin: fix template creation resource issues #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...les/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,11 +1326,9 @@ private void onNewTemplate() {
return;
}

if (!model.validateNaming()) {
return;
}

if (model.getIsSubTemplate().getEntity()) {
if (!model.validate(false)) {
model.setIsValid(false);
} else if (model.getIsSubTemplate().getEntity()) {
postNameUniqueCheck();
} else {
String name = model.getName().getEntity();
Expand Down Expand Up @@ -2193,7 +2191,7 @@ public void executeCommand(UICommand command) {
}

protected void exportOva() {
VM selectedEntity = (VM) getSelectedItem();
VM selectedEntity = getSelectedItem();
if (selectedEntity == null) {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions ...mmonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1694,17 +1694,17 @@ public void updateMaxMemory() {
}

public void updateMemory() {
Integer memoryMb = getModel().getMemSize().getEntity();
AsyncDataProvider.getMinMemoryForOs(new AsyncQuery<>(minMemory -> {
Integer memoryMb = getModel().getMemSize().getEntity();
if (memoryMb == null || memoryMb < minMemory) {
getModel().getMemSize().setEntity(minMemory);
}
}), getSelectedOSType(), getCompatibilityVersion());
}

public void updateTotalCpuCores() {
int cpuCores = getTotalCpuCores();
AsyncDataProvider.getMinCpus(new AsyncQuery<>(minCpus -> {
int cpuCores = getTotalCpuCores();
if (cpuCores < minCpus) {
getModel().getTotalCPUCores().setEntity(Integer.toString(minCpus));
}
Expand Down