Team-4-submission - #8
Open
waynewangyuxuan wants to merge 5 commits into
Open
Conversation
|
do you have a CI link i can look at? |
Author
|
https://app.circleci.com/pipelines/circleci/XuhSKKLtTmft9W3VV6Pa6t/Pht6yzSCo6GJvUbVC1gNV8
Hi professor, this is the link.
…On Tue, Oct 8, 2024 at 9:42 PM Kamen Yotov ***@***.***> wrote:
do you have a CI link i can look at?
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYEIBD257F3ZB5GC66ZO46TZ2SCZFAVCNFSM6AAAAABPRDIMGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGEYDKOJQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
seems like you can do a bit more to integrate this part? |
Author
|
We overlooked this part before…
I think we can.
Btw, the ci/cd on master, the (most recent ) failed one, is what we intend
to show you. The ci/cd did not past because we did not pass the clang-tidy
check. We put the clang-tidy into crest, wondering whether we should do it
at build or do it with ctest like it is?
…On Tue, Oct 8, 2024 at 9:51 PM Kamen Yotov ***@***.***> wrote:
seems like you can do a bit more to integrate this part?
image.png (view on web)
<https://github.com/user-attachments/assets/e4960487-f149-484f-9a27-b447d4c4714c>
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYEIBD3FO4A3QEF2PGIDTZ3Z2SDYJAVCNFSM6AAAAABPRDIMGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGEYTEOBYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kyotov
requested changes
Oct 30, 2024
kyotov
left a comment
kyotov
left a comment
There was a problem hiding this comment.
please address the comments and let me know when it is ready for another look
| jobs: | ||
| build-test: | ||
| docker: | ||
| - image: cimg/base:current |
There was a problem hiding this comment.
for extra credit you can build your own image, but for this hw, this is ok
Comment on lines
+15
to
+30
| - run: | ||
| name: Build | ||
| command: | | ||
| echo "Building" | ||
| mkdir build && cd build | ||
| cmake -S .. | ||
| make -j $(nproc) | ||
| cd ../ | ||
| echo "Built" | ||
| - run: | ||
| name: Test | ||
| command: | | ||
| echo "Start Testing" | ||
| cd build | ||
| ctest | ||
| echo "Testing Done" |
Comment on lines
+317
to
+340
| set(NINJA_TEST_SOURCES | ||
| src/build_log_test.cc | ||
| src/build_test.cc | ||
| src/clean_test.cc | ||
| src/clparser_test.cc | ||
| src/depfile_parser_test.cc | ||
| src/deps_log_test.cc | ||
| src/disk_interface_test.cc | ||
| src/dyndep_parser_test.cc | ||
| src/edit_distance_test.cc | ||
| src/elide_middle_test.cc | ||
| src/explanations_test.cc | ||
| src/graph_test.cc | ||
| src/json_test.cc | ||
| src/lexer_test.cc | ||
| src/manifest_parser_test.cc | ||
| src/missing_deps_test.cc | ||
| src/ninja_test.cc | ||
| src/state_test.cc | ||
| src/string_piece_util_test.cc | ||
| src/subprocess_test.cc | ||
| src/test.cc | ||
| src/util_test.cc | ||
| ) |
There was a problem hiding this comment.
this looks like something that should be in the original ninja?
what is the purpose?
Author
There was a problem hiding this comment.
Oh, we will delete this in here, we did not write any code at the time, so we were checking the src code see whether clang-tidy was working
Comment on lines
+344
to
+351
| if(CLANG_TIDY_EXE) | ||
| add_test( | ||
| NAME clang-tidy-check | ||
| COMMAND ${CLANG_TIDY_EXE} ${NINJA_TEST_SOURCES} --checks=-*,modernize-* --warnings-as-errors=* | ||
| ) | ||
| else() | ||
| message(WARNING "clang-tidy not found, skipping clang-tidy test") | ||
| endif() |
There was a problem hiding this comment.
i see that you run it now, but this is not the normal way to run clang-tidy in cmake (i think)...
can you check?
Author
There was a problem hiding this comment.
I think you are right about this, we will update this
Author
Hi, professor, the use of clang-tidy is fixed |
kyotov
reviewed
Nov 7, 2024
|
|
||
| name: Run Tests | ||
| command: | | ||
| ./cicd-build/ninja_test |
waynewangyuxuan
force-pushed
the
master
branch
from
November 10, 2024 01:40
1793eeb to
84f27af
Compare
Add a new class to wrap the logic needed to implement the `inputs` tool correctly (see Issue ninja-build#2482 for details), and provide a unit-test for it.
This uses the InputsCollector class introduced in the previous patch to implement the tool properly. Results are still shell-escaped and sorted alphabetically. Fixed ninja-build#2482
Add new options to the `inputs` tool in order to change the format of its output: - `--no-shell-escape` to avoid shell-escaping the results. - `--dependency-order` to return results in dependency order, instead of sorting them alphabetically. - `--print0` to use \0 as the list separator in the list, useful to process the target paths with `xargs -0` and similar tools.
CircleCI Commit Update CI update README.md add sudo Updated CMakeLists.txt to include clang-tidy configuration change clang test name update clangtest file update clang-tidy/circleCI use. Learned from team5's implementation update yml file typos init CircleCI Commit Update CI update README.md add sudo test folder wrong
waynewangyuxuan
force-pushed
the
master
branch
2 times, most recently
from
November 10, 2024 20:22
516d7b4 to
eaa07e0
Compare
Added ctest and performance test. Try to show test on CI/CD dashboard, followed the instruction, however we could not get it working somehow.
waynewangyuxuan
force-pushed
the
master
branch
from
November 10, 2024 20:24
eaa07e0 to
75a9412
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged Commits into 2