Team 5 - New Language Design - #31
Open
qianxichen233 wants to merge 1 commit into
Open
Conversation
update manifest Add comments and documentation to shadowdash_manifest.h & manifest_example.cc added documentation for shadowdash added gitignore updated added manifest_compile.sh updated manifest_compile.sh updated cmakelist
|
Code Review From @yw5490 @395110n @cchels
|
|
@cchels CircleCI link is included in the PR description. Please see above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the new language design task for Team 5.
The implementation included in this PR is our first iteration of the new language design. It constructs the graph relationships and then translates Shadowdash’s graph representation into Ninja’s representation. While we have a newer iteration that directly translates to Ninja’s graph representation during class construction (available at PR #20), that version is still undergoing frequent updates to meet performance expectations and is not final. As a result, we are submitting this earlier iteration, which uses the older approach, as the PR’s content.
Related Files and Their Functionality (in Suggested Review Order):
shadowdash_docs/new_language_doc.md: Documentation detailing how to use the new language.shadowdash_test/manifest.h: Contains the core of the new language design.shadowdash_test/manifest_example.cc: Provides an example manifest that demonstrates how to use the new language..circleci/config.yml: Adds a test step for the new language design example.shadowdash_test/manifest_compile.sh: Test script for verifying the new language functionality..gitignore: Updated to ignore .so files.Here is the link to the successful CircleCI run.