Skip to content

Team 4 shadowdash new language design - #22

Open
waynewangyuxuan wants to merge 1 commit into
nyuoss:team-4-languagefrom
YuWei-CH:new-language-submission
Open

Team 4 shadowdash new language design#22
waynewangyuxuan wants to merge 1 commit into
nyuoss:team-4-languagefrom
YuWei-CH:new-language-submission

Conversation

@waynewangyuxuan

Copy link
Copy Markdown

Commits combined into one.

@waynewangyuxuan waynewangyuxuan changed the title shadowdash new language design Team 4 shadowdash new language design Nov 24, 2024
@yw5490

yw5490 commented Nov 24, 2024

Copy link
Copy Markdown

Test Plan:
Added the following test to be automatically performed by Circle CI:

check_success() {
  if [ $? -eq 0 ]; then
    echo "$1"
  else
    echo "$1"
    exit 1
  fi
}

cd src/shadowdash

g++ -w -std=c++17 -fPIC -c manifest.cc  manifest.h
check_success ".o compiled successfully"

g++ -w -shared -o manifest.so manifest.o
check_success ".so compiled successfully"

cd ../..

Test Result:
Overall Test
Test to compile manifest.o and manifest.so

@kyotov kyotov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you are following general comments i have in https://docs.google.com/document/d/11e8zR3kcm7B-D6brAH_D4OgtYBEf94GZwQIXrnti5hM/edit?tab=t.0 and let me know to look again.
(not all points apply to you but some do)

@yw5490

yw5490 commented Dec 10, 2024

Copy link
Copy Markdown

Latest PR: #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants