Mini Task - mAIgic Team 3 - Gmail Communication - #13
Open
TechPertz wants to merge 3 commits into
Open
Conversation
|
If using uv, it won't allow leaving |
PR Review according to the provided template / guidelines.Change Granularity:
Code Functionality:
Readability & Structure:
Standards Compatibility:
Testing:
|
|
Change Granularity: I think the commits have good messages and none are overloaded Code Functionality: The code works as expected. The files are named appropriately for the functionality they provide Readability: There are barely any comments, and the comments aren't that descriptive Standards Compatibility: I think it complies with standard SWE practices, looks good to me! Testing: The tests cover all edgecases, and the naming is helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new PR for the gmail communication mini-task. Although numerous function and files were added beyond this stage, this PR follows the mini task that was initially assigned. This code establishes communication with the gmail server as per the requirements.
Members:
Reet Nandy [rn2528@nyu.edu]
Anushka Tawte [at5849@nyu.edu]
Rafael [rdl404@nyu.edu]