fix: register site URL for runtime overrides - #386
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
better-auth | 23c115a | Aug 06 2026, 06:11 PM |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtimeConfig.public.siteUrlso Nuxt can applyNUXT_PUBLIC_SITE_URLafter the app is builtWhy
Nuxt runtime environment variables only override keys present in the built runtime config. A generic image built without
NUXT_PUBLIC_SITE_URLcurrently omitspublic.siteUrl, so supplying the variable when the server starts has no effect and eventlessserverAuth()can fail to resolve its base URL.Registering an empty default keeps the key in the build while retaining the existing precedence rules. This change is intentionally independent from #87 and does not include Nitro 3 compatibility work.
Testing
pnpm exec vitest run test/runtime-config.test.ts test/server-auth-base-url-cache.test.ts(16 tests)pnpm typecheckpnpm lintbase-url-inferencefixture withNUXT_PUBLIC_SITE_URLunset, then started the built Node server withNUXT_PUBLIC_SITE_URL=https://runtime.example.test; eventlessserverAuth()resolvedbaseURLtohttps://runtime.example.test