[MDPA] Improve support for Kratos Multiphysics mdpa support - #1553
Closed
loumalouomega wants to merge 21 commits into
Closed
[MDPA] Improve support for Kratos Multiphysics mdpa support#1553loumalouomega wants to merge 21 commits into
loumalouomega wants to merge 21 commits into
Conversation
Author
|
Looks like some tests in the main are failing, I will try to fix them, and cherry-pick in an independent branch |
Author
|
Includes #1554 |
added 15 commits
April 8, 2026 15:27
- Replace | with Union in type hints for compatibility with Python < 3.10 - Add missing topological_dimension import in meshio/__init__.py - Update tox.ini and CI to explicitly use py38 and py312 environments - Ensure tox uses the correct environment version in GitHub Actions
- Use math.prod in VTK writers (as suggested in code) - Fix argparse subparser compatibility - Refine __about__.py version discovery - General cleanup of type hints and imports
…ons and clean up MDPA read logic
Author
|
Okay, now passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request significantly expands and robustifies the support for the Kratos Multiphysics MDPA format. It transforms the MDPA module from a basic reader/writer into a comprehensive tool capable of handling complex simulation setups with high fidelity.
Key Enhancements
1. Expanded Entity Mapping
Element3D4N,Element2D3N,SurfaceCondition3D3N,LineCondition2D2N).2. High-Fidelity Round-Trips via
misc_datamesh.misc_datato preserve MDPA-specific metadata that doesn't fit the standard meshio model:3. Hierarchical SubModelPart Support
Begin/Endblocks.4. Corrected Node Ordering (Permutations)
hexahedron20andhexahedron27).5. Robust Parser Improvements
Begin Elements Element3D4N // comment).Testing Improvements
.mdpafiles intests/meshes/mdpa/to verify real-world scenarios.test_*.mdpaconvention.Code Quality
isortandblackstyling to all modified files.flake8linting issues.