Skip to content

Enable docker build by only cloning the repository #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Checker8763 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable docker build by only cloning the repository #604

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f86cd6
Update setup.py
Checker8763 May 17, 2025
fff5bc8
Update Dockerfile
Checker8763 May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
author="Joel Martin",
author_email="github@martintribe.org",

packages=['websockify'],
packages=find_packages(),

@CendioOssman CendioOssman May 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is a plus, given we have such a simple project. Explicitly listing them gives you some protection against including any random junk that people might have in their working copy.

@Checker8763 Checker8763 May 26, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why, but I only got it to work succesful this way.

When explicity stating the package, the build always fails with a message that the folder or package can not be found, even if they have the exact same name as the directory it is in...

I can do some tests again and give the error message maybe somone meight have more insight and makes the build without needing this change.

@CendioOssman CendioOssman Jun 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do and share the error here.

@Checker8763 Checker8763 Jun 8, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#604 (comment)

I posted into the wrong comment...

include_package_data=True,
install_requires=[
'numpy', 'requests',
Expand Down