Skip to content

Add lint workflow #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notypecheck wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add lint workflow #601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a994cd8
build: migrate from `setup.py` to `pyproject.toml`
notypecheck Mar 12, 2025
4fc7e52
ci: add lint workflow
notypecheck Mar 12, 2025
3eca8ad
run `ruff format .`
notypecheck Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ target.cfg.d
build/
dist/
*.egg-info

# Intellij IDEs
.idea
Comment on lines +13 to +15

@CendioZeijlon CendioZeijlon Apr 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local settings folders/files shouldn't be added to the repo.

@notypecheck notypecheck Apr 14, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought intellij-based ide's are kind of common and adding that to .gitignore made sense, so contributors don't have do do that themselves. I can remove that if you want though.

51 changes: 51 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
[project]
name = "websockify"
version = "0.13.0"
description = "Websockify."
readme = "README.md"
authors = [
{ name = "Joel Martin", email = "github@martintribe.org" }
]
requires-python = ">=3.6"
dependencies = [
"jwcrypto>=1.5.1",
"numpy>=1.19.0",
"redis>=4.3.0",
"requests>=2.27.0",
Comment on lines +11 to +14

@CendioZeijlon CendioZeijlon Apr 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about targeting versions here, where did these come from?

@notypecheck notypecheck Apr 14, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're probably the latest compatible releases with 3.7, I don't quite remember if I pulled these manually or uv did it.

]
classifiers = [
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
keywords = ["noVNC", "websockify"]
license = { text = "LGPLv3" }

[project.urls]
Repository ="https://github.com/novnc/websockify"

[project.scripts]
websockify = "websockify.websocketproxy:websockify_init"

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"


[tool.hatch.build.targets.wheel]
packages = [
"websockify",
]

[dependency-groups]
dev = [
"mypy>=0.971",
"ruff>=0.0.17",
]
Loading