You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ide-outils hello, could you please merge the pr/307/ide-outils/rename-buffer-to-buf-for-autocmds-api-0.12.2/amend from my fork into your PR.
What it does:
deprecate rather than disable buffer for *autocmds on neovim-0-12+
Sets the neovim-0-12 feature gate to deprecate the .buffer field for ClearAutocmdsOpts, CreateAutocmdOpts, ExecAutocmdsOpts and GetAutocmdsOpts instead of disabling it.
Rationale: As discussed in #309, NVIM 0.12.2 added the buf field but to maintain backwards compatibility it did not remove the buffer field only marked it as deprecated.
As such the buffer field must remain in the *Autocmd* structs for neovim-0-12 and neovim-nightly, but it seems appropriate to also mark it a deprecated.
duplicate autocmd tests for buf and buffer
Copies tests/autocmd.rs into tests/autocmd_neovim_0_11.rs.
Feature gates tests/autocmd_neovim_0_11.rs and tests/autocmd.rs in tests/mod.rs.
Renames the buffer field to buf in tests/autocmd.rs.
Adds a single set_get_exec_clear_autocmd_buffer test to tests/autocmd.rs.
Rationale: Since the buffer field is considered as deprecated it seems appropriate to switch the tests for neovim-0-12 and neovim-nightly to the new buf field.
Until neovim-0-11 is dropped it's necessary to keep testing for the buffer field too.
It feels cleaner to so in two separate test files with a single feature gate on their import instead of feature gating each of the duplicated tests.
A single test checking that the deprecated buffer field is still working in neovim-0-12 and neovim-nightly seems reasonable.
c-c-k
pushed a commit
to nvim-oxi-community/nvim-oxi
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #306.