Fix PartialFillExchange exact-qty fills and local partial-fill accounting - #323
Open
vedjaw wants to merge 1 commit into
Open
Fix PartialFillExchange exact-qty fills and local partial-fill accounting#323vedjaw wants to merge 1 commit into
vedjaw wants to merge 1 commit into
Conversation
…ting Treat filled_qty == leaves_qty as a complete fill (>=) so InvalidOrderStatus is not raised when the queue model reports an exact fill (nkaz001#312). Apply PartiallyFilled responses on the local side so position/balance track incremental exec_qty (nkaz001#316). Co-authored-by: Cursor <cursoragent@cursor.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filled_qty == leaves_qtyas a complete fill (>=) inPartialFillExchange, avoidingInvalidOrderStatuswhen the queue model reports an exact fill (Bug: PartialFillExchange fails with InvalidOrderStatus when filled_qty == leaves_qty #312).PartiallyFilledresponses on the local processors (Local/L3Local) so position and balance track each incrementalexec_qty(Partial fills of resting orders are never applied to position/balance (PartialFillExchange + prob queue models) #316).Test plan
position/balanceshould move on each partial, and exactfilled_qty == leaves_qtyshould complete without errorFixes #312
Fixes #316
Made with Cursor