Support old PHP versions - #482
Conversation
|
Thanks for that. @tinybeachthor pinging you in case you'd like tor review this. |
| # php with required extensions | ||
| php = | ||
| if satisfies pkgs.php81.version subsystemAttrs.phpSemver | ||
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; |
There was a problem hiding this comment.
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
| phpPackages = l.attrValues (import inputs.phps).packages.x86_64-linux; |
There was a problem hiding this comment.
For my own understanding, what does import do here?
There was a problem hiding this comment.
Instead of treating inputs.php like a flake, it treats it as a path and imports it. Currently we have a failing CI tests, because under some circumstances inputs.php is a path and not a flake. This is buggy behavior in our backward compat mechanism which I don't intend to fix anymore in favor of the upcoming v1 API changes.
| # php with required extensions | ||
| php = | ||
| if satisfies pkgs.php81.version subsystemAttrs.phpSemver | ||
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; |
There was a problem hiding this comment.
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; | |
| phpPackages = l.attrValues (import inputs.phps).packages.x86_64-linux; |
| # php with required extensions | ||
| php = | ||
| if satisfies pkgs.php81.version subsystemAttrs.phpSemver | ||
| phpPackages = l.attrValues inputs.phps.packages.x86_64-linux; |
There was a problem hiding this comment.
Probably does not make much difference, maybe passing system attribute here instead of hard-coding x86_64-linux.
|
|
|
Will php still work with the V1 api? |
4 participants
As suggested in #240, adds support for all stable php versions from https://github.com/fossar/nix-phps